From: Bruce Cran <bruce@cran.org.uk>
To: "Jeffrey McVay (jmcvay)" <jmcvay@micron.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: FIO 2.0.9 for Windows Server 2008 RC1 SP2 reports extreme latencies
Date: Wed, 10 Oct 2012 11:41:31 +0100 [thread overview]
Message-ID: <507550DB.2000301@cran.org.uk> (raw)
In-Reply-To: <507548FE.9010106@cran.org.uk>
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
On 10/10/2012 11:07, Bruce Cran wrote:
> The problem is that windowsaio iterates over the list of outstanding
> IOs (busylist), but that list has the most recent first.
The attached patch appears to fix the problem:
Add outstanding IOs to the tail of io_u_busylist, not the head.
--
Bruce Cran
[-- Attachment #2: aio_queue.diff --]
[-- Type: text/plain, Size: 356 bytes --]
diff --git a/io_u.c b/io_u.c
index a2c583d..e047677 100644
--- a/io_u.c
+++ b/io_u.c
@@ -1096,7 +1096,7 @@ again:
io_u->error = 0;
flist_del(&io_u->list);
- flist_add(&io_u->list, &td->io_u_busylist);
+ flist_add_tail(&io_u->list, &td->io_u_busylist);
td->cur_depth++;
io_u->flags |= IO_U_F_IN_CUR_DEPTH;
} else if (td->o.verify_async) {
next prev parent reply other threads:[~2012-10-10 10:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 5:41 FIO 2.0.9 for Windows Server 2008 RC1 SP2 reports extreme latencies Jeffrey McVay (jmcvay)
2012-09-24 13:28 ` Bruce Cran
2012-09-26 16:30 ` Jeffrey McVay (jmcvay)
2012-09-26 16:32 ` Bruce Cran
2012-09-29 6:23 ` Jens Axboe
2012-09-29 13:46 ` Bruce Cran
2012-09-29 14:21 ` Jens Axboe
2012-10-06 0:25 ` Jeffrey McVay (jmcvay)
2012-10-10 10:07 ` Bruce Cran
2012-10-10 10:41 ` Bruce Cran [this message]
2012-10-10 14:15 ` Jens Axboe
2012-10-10 14:18 ` Bruce Cran
2012-10-10 14:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507550DB.2000301@cran.org.uk \
--to=bruce@cran.org.uk \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jmcvay@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox