Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Alex Pyrgiotis <apyrgio@grnet.gr>
To: Jiri Horky <jiri.horky@cesnet.cz>
Cc: fio@vger.kernel.org, synnefo-devel@googlegroups.com
Subject: Re: [PATCH 2/2] Add a simple test for LFSR generator
Date: Tue, 12 Mar 2013 08:45:15 +0200	[thread overview]
Message-ID: <513ECEFB.1060803@grnet.gr> (raw)
In-Reply-To: <513DFD85.2080107@cesnet.cz>

On 03/11/2013 05:51 PM, Jiri Horky wrote:
> Hi Alex,
>
> I just used your implementation in a different project as well, thanks 
> for it :) One small correction, I think that the last line of:
>
> On 03/08/2013 01:37 PM, Alex Pyrgiotis wrote:
>> +    /* Check if all expected numbers within range have been 
>> calculated */
>> +    r = 0;
>> +    if (verify) {
>> +        fprintf(stderr, "Verifying results... ");
>> +        for (i = 0; i < numbers; i++) {
>> +            if (*(uint8_t *)(v + 1) != 1) {
> should be:
>
>             if (*(uint8_t *)(v + i) != 1) {
>
> (not +1, but +i).
>
>

Hi Jiri,

I'm glad you found the implementation useful.
Your observation is correct. I'll send a new patch that fixes this 
issue, among other things.

Thanks,
Alex

-- 
Alex | apyrgio@grnet.gr


  reply	other threads:[~2013-03-12  6:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 12:37 [PATCH 0/2] Proposed LFSR implementation Alex Pyrgiotis
2013-03-08 12:37 ` [PATCH 1/2] Improve " Alex Pyrgiotis
2013-03-08 12:37 ` [PATCH 2/2] Add a simple test for LFSR generator Alex Pyrgiotis
2013-03-11 15:51   ` Jiri Horky
2013-03-12  6:45     ` Alex Pyrgiotis [this message]
2013-03-11 11:27 ` [PATCH 0/2] Proposed LFSR implementation Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2013-03-08 18:30 Alex Pyrgiotis
2013-03-08 18:30 ` [PATCH 2/2] Add a simple test for LFSR generator Alex Pyrgiotis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513ECEFB.1060803@grnet.gr \
    --to=apyrgio@grnet.gr \
    --cc=fio@vger.kernel.org \
    --cc=jiri.horky@cesnet.cz \
    --cc=synnefo-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox