Flexible I/O Tester development
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: Jens Axboe <JAxboe@fusionio.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: [PATCH] mutex: fix the expression for checking the mutext magic.
Date: Fri, 22 Mar 2013 00:13:40 -0600	[thread overview]
Message-ID: <514BF694.2090004@gmail.com> (raw)

Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
 mutex.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/mutex.c b/mutex.c
index af5e501..6022cdd 100644
--- a/mutex.c
+++ b/mutex.c
@@ -20,7 +20,7 @@
 
 void fio_mutex_remove(struct fio_mutex *mutex)
 {
-    assert(mutex->magic = FIO_MUTEX_MAGIC);
+    assert(mutex->magic == FIO_MUTEX_MAGIC);
     pthread_cond_destroy(&mutex->cond);
     munmap((void *) mutex, sizeof(*mutex));
 }
@@ -95,7 +95,7 @@ int fio_mutex_down_timeout(struct fio_mutex *mutex, unsigned int seconds)
     struct timespec t;
     int ret = 0;
 
-    assert(mutex->magic = FIO_MUTEX_MAGIC);
+    assert(mutex->magic == FIO_MUTEX_MAGIC);
 
     gettimeofday(&tv_s, NULL);
     t.tv_sec = tv_s.tv_sec + seconds;
@@ -127,7 +127,7 @@ int fio_mutex_down_timeout(struct fio_mutex *mutex, unsigned int seconds)
 
 void fio_mutex_down(struct fio_mutex *mutex)
 {
-    assert(mutex->magic = FIO_MUTEX_MAGIC);
+    assert(mutex->magic == FIO_MUTEX_MAGIC);
 
     pthread_mutex_lock(&mutex->lock);
 
@@ -143,7 +143,7 @@ void fio_mutex_down(struct fio_mutex *mutex)
 
 void fio_mutex_up(struct fio_mutex *mutex)
 {
-    assert(mutex->magic = FIO_MUTEX_MAGIC);
+    assert(mutex->magic == FIO_MUTEX_MAGIC);
 
     pthread_mutex_lock(&mutex->lock);
     read_barrier();
@@ -155,25 +155,25 @@ void fio_mutex_up(struct fio_mutex *mutex)
 
 void fio_rwlock_write(struct fio_rwlock *lock)
 {
-    assert(lock->magic = FIO_RWLOCK_MAGIC);
+    assert(lock->magic == FIO_RWLOCK_MAGIC);
     pthread_rwlock_wrlock(&lock->lock);
 }
 
 void fio_rwlock_read(struct fio_rwlock *lock)
 {
-    assert(lock->magic = FIO_RWLOCK_MAGIC);
+    assert(lock->magic == FIO_RWLOCK_MAGIC);
     pthread_rwlock_rdlock(&lock->lock);
 }
 
 void fio_rwlock_unlock(struct fio_rwlock *lock)
 {
-    assert(lock->magic = FIO_RWLOCK_MAGIC);
+    assert(lock->magic == FIO_RWLOCK_MAGIC);
     pthread_rwlock_unlock(&lock->lock);
 }
 
 void fio_rwlock_remove(struct fio_rwlock *lock)
 {
-    assert(lock->magic = FIO_RWLOCK_MAGIC);
+    assert(lock->magic == FIO_RWLOCK_MAGIC);
     munmap((void *) lock, sizeof(*lock));
 }
 
-- 
1.8.2.rc2.4.g7799588



             reply	other threads:[~2013-03-22  6:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22  6:13 majianpeng [this message]
2013-03-22 13:15 ` [PATCH] mutex: fix the expression for checking the mutext magic Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514BF694.2090004@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=JAxboe@fusionio.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox