Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: asomers@gmail.com
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: --minimal does not work in client/server mode
Date: Mon, 29 Jul 2013 10:23:03 -0600	[thread overview]
Message-ID: <51F696E7.1070206@kernel.dk> (raw)
In-Reply-To: <CAOtMX2ji_t2MOA_9akkyAkXd=R6sO7V1nWiBfesLFJ5SPg+fdw@mail.gmail.com>

On 07/29/2013 10:00 AM, asomers@gmail.com wrote:
> I found a few more things that need to be suppressed in terse mode.
> The updated patch is here.  In addition to working with JSON output,
> we also need to check that the patch doesn't break disk statistics.  I
> haven't tried using those at all yet.
> 
> https://gist.github.com/asomers/6105396

I would suggest making a show_thread_status_all() that does something ala:

void show_thread_status_all()
{
   if (is_backend)
       fio_server_send_ts(ts, rs);
   else if (output_format == FIO_OUTPUT_TERSE)
       show_thread_status_terse(ts, rs);
   else if (output_format == FIO_OUTPUT_JSON) {
       struct json_object *tmp = show_thread_status_json(ts, rs);

       json_array_add_value_object(array, tmp);
   } else
       show_thread_status(ts, rs);
}

which should work for all. If you could check and fix the json bit too,
bonus points, and I'll test and commit it. Thanks!


-- 
Jens Axboe


  reply	other threads:[~2013-07-29 16:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 23:16 --minimal does not work in client/server mode asomers
2013-07-29 15:02 ` Jens Axboe
2013-07-29 16:00   ` asomers
2013-07-29 16:23     ` Jens Axboe [this message]
2013-08-29 22:23       ` asomers
2013-08-29 22:24       ` asomers
2013-08-29 22:26       ` asomers
2013-08-31  4:29         ` Jens Axboe
2013-08-29 22:29       ` asomers
  -- strict thread matches above, loose matches on Subject: below --
2017-06-29 23:51 Nisha Miller
2017-06-30  3:17 ` Sitsofe Wheeler
2017-06-30 21:59   ` Nisha Miller
2017-06-30 23:06   ` Nisha Miller
2017-06-30 23:46     ` Sitsofe Wheeler
2017-07-01  0:05       ` Nisha Miller
2017-07-01  8:57         ` Sitsofe Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F696E7.1070206@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asomers@gmail.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox