Re: [PATCH 5/9] introduce the log_issue_time option

[Damien Le Moal <dlemoal@kernel.org>]

On 8/29/24 02:38, Nick Neumann wrote:
> Do you have any thoughts on eventually including the submit time or
> submit latency in the clat file as well? Then one would have a single
> file without any of the redundancies involved with multiple files.

The submit time is what Shin'ichiro patches are adding :)
issue time == submit time. Maybe we should change the name to log_submit_time ?

With the code refactoring/cleanup that Shin'ichiro did, the submit latency can
easily be added too. Though one could argue that the "clat" name for the log
then becomes a little inappropriate.

> I've also thought a bit about having a non-text but portable output
> file option, like protobuf. The files are large, and gzip compresses
> the per-I/O logs well, but I imagine protobuf would be a big win for
> both outputting and ingesting the log files, and would be way smaller
> than the non-compressed log files.

Adding an option to change the clat file format can be done on top of this series.

> 
> Thanks for the new feature and any input on my thoughts!
> - Nick

-- 
Damien Le Moal
Western Digital Research