From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <erwan@enovance.com>
Message-ID: <521DA341.3050707@enovance.com>
Date: Wed, 28 Aug 2013 09:14:09 +0200
From: Erwan Velu <erwan@enovance.com>
MIME-Version: 1.0
Subject: Re: [PATCH 2/2] Adds check for rand_seed during verify phase.
References: <1377552162-31741-1-git-send-email-jcasse@chromium.org> <1377552162-31741-2-git-send-email-jcasse@chromium.org> <CANEJEGuKzZeLfCoNX12Pp_4_Uj8iHjLX221c+qpYzgpWYgA-Pg@mail.gmail.com>
In-Reply-To: <CANEJEGuKzZeLfCoNX12Pp_4_Uj8iHjLX221c+qpYzgpWYgA-Pg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Grant Grundler <grundler@chromium.org>
Cc: Juan Casse <jcasse@chromium.org>, Jens Axboe <axboe@kernel.dk>, FIO_list <fio@vger.kernel.org>
List-ID: <fio@vger.kernel.org>

On 27/08/2013 00:11, Grant Grundler wrote:
> Jens, et al,
>
> In general I'm ok with this patch...just one issue I'd like to get an
> opinion on...
>
I don't have the skill to make a technical review of it.

At least, I'm a great fan of well detailed commits.
At my taste, I do like when a commit does explain what was the problem 
and what is the solution.

A single line for such commit seems a little bit light for me.

Cheers,