From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <52244E75.5070405@enovance.com> Date: Mon, 02 Sep 2013 10:38:13 +0200 From: Erwan Velu MIME-Version: 1.0 Subject: Re: [PATCH 2/2] Adds check for rand_seed during verify phase. References: <1377552162-31741-1-git-send-email-jcasse@chromium.org> <1377552162-31741-2-git-send-email-jcasse@chromium.org> <521DA341.3050707@enovance.com> <20130831043119.GU21481@kernel.dk> In-Reply-To: <20130831043119.GU21481@kernel.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Jens Axboe Cc: Grant Grundler , Juan Casse , FIO_list List-ID: On 31/08/2013 06:31, Jens Axboe wrote: > [...] > Agree. A good commit message describes the need for the change. It needs > to justify its own inclusion, so to speak. Basically it answers the key > question of why this change is needed. > I don't know how you play with fio, but on my project I'm working on, that's a good reason to refuse a patch even if the code is correct :o) Cheers, Erwan