From: Erwan Velu <erwan@enovance.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: How to loop a timebased job
Date: Wed, 04 Sep 2013 15:56:05 +0200 [thread overview]
Message-ID: <52273BF5.90109@enovance.com> (raw)
In-Reply-To: <20130903223727.GB31170@kernel.dk>
On 04/09/2013 00:37, Jens Axboe wrote:
> It should work, if it doesn't, I agree it's a bug. It's not certain
> than anyone has considered this specific use case before. Feel free to
> fix! Or I can take a look at it tomorrow.
I think I found the issue but my main question is about priority.
If both time & loops are set, what shall be considered as the key
element to stop the benchmark.
Today, time have the priority over loops as keep_running() returns if
time_based while time is handled in do_io().
If I do remove this test in keep_running, the first of the two getting
the limit will stop the job.
On one hand, we have timebased option to insure time over end of device.
Shall we put a loopbased on the other hand ?
My 2 cents,
Erwan
next prev parent reply other threads:[~2013-09-04 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 19:34 How to loop a timebased job Erwan Velu
2013-09-03 22:37 ` Jens Axboe
2013-09-04 13:56 ` Erwan Velu [this message]
2013-09-04 17:52 ` Jens Axboe
2013-09-04 20:02 ` Erwan Velu
2013-09-04 20:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52273BF5.90109@enovance.com \
--to=erwan@enovance.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox