From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <53179398.9000300@kernel.dk> Date: Wed, 05 Mar 2014 14:14:00 -0700 From: Jens Axboe MIME-Version: 1.0 Subject: Re: regression since 2.1.3 (solaris/zfs) References: <1E602C14-0C00-4258-94C2-8F16A56C509D@coraid.com> <53149EF3.7020005@kernel.dk> <53174E4C.90402@kernel.dk> <9F498F1D-A6EC-4012-B6CC-271EEA8F4F32@coraid.com> <531791B5.2010606@kernel.dk> <5ED3076B-B15B-42B1-8AD4-500B62D19EFA@coraid.com> In-Reply-To: <5ED3076B-B15B-42B1-8AD4-500B62D19EFA@coraid.com> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable To: "Robin P. Blanchard" Cc: "fio@vger.kernel.org" List-ID: On 03/05/2014 02:12 PM, Robin P. Blanchard wrote: > > On Mar 5, 2014, at 16:05 PM, Jens Axboe wrote: > >> On 03/05/2014 01:39 PM, Robin P. Blanchard wrote: >>> >>> On Mar 5, 2014, at 12:06 PM, Jens Axboe wrote: >>> >>>> On Mar 5, 2014, at 9:27 AM, Robin P. Blanchard wrot= e: >>>> >>>>> >>>>> On Mar 5, 2014, at 11:18 AM, Jens Axboe wrote: >>>>> >>>>>> On 2014-03-05 09:11, Robin P. Blanchard wrote: >>>>>>> >>>>>>> On Mar 3, 2014, at 10:25 AM, Jens Axboe wrote: >>>>>>> >>>>>>>> On 03/02/2014 07:59 AM, Robin P. Blanchard wrote: >>>>>>>>> My config file has direct=3D0, which until 2.1.4 worked as expect= ed. >>>>>>>>> Things seem to regress since. >>>>>>>>> >>>>>>>>> I apologize in advance if this has already been reported. Please >>>>>>>>> let me know what I can do to further help (truss/debug). >>>>>>>> >>>>>>>> This isn't a known issue, so thanks for reporting it. The easiest = way to debug this is to git bisect it. Looks like you are running from the = tar balls, but I assume you have git installed? I'm assuming fio-2.1.3 work= ed for you - if not, just replace fio-2.1.3 in the below with whatever late= st version did work. If you do, the cheat sheet is something ala: >>>>>>>> >>>>>>>> $ git clone git://git.kernel.dk/fio >>>>>>>> $ cd fio; make >>>>>>>> $ git bisect start >>>>>>>> $ git bisect good fio-2.1.3 >>>>>>>> $ git bisect bad fio-2.1.4 >>>>>>>> >>>>>>>> This starts the bisect series, now do: >>>>>>>> >>>>>>>> $ make clean; make >>>>>>>> >>>>>>>> and re-run your direct=3D0 job file. If it worked, then you do >>>>>>>> >>>>>>>> $ git bisect good >>>>>>>> >>>>>>>> and if not, you do git bisect bad instead. This gets you a new poi= nt in the tree to test, so repeat the make clean; make and re-run the test. >>>>>>>> Keep doing this good/bad iteration until fio tells you what commit= broke the test for you. Then send those results here! >>>>>>>> >>>>>>>> -- >>>>>>>> Jens Axboe >>>>>>>> >>>>>>> >>>>>>> >>>>>>> Here=EF=BF=BDs where it started working again: >>>>>>> >>>>>>> # git bisect good >>>>>>> Bisecting: 4 revisions left to test after this (roughly 2 steps) >>>>>>> [3bb0a7b0fda9945973f799ab253c70d3cb0e5c8b] howto: Fix redundant ent= ries >>>>>>> >>>>>>> Let me know how else I can help. >>>>>> >>>>>> Please keep going until it tells you what the definitively bad commi= t is. It'll end up spitting out that info, if you keep doing git bisect goo= d/bad on each test point. You need just ~2 more tests after this one. >>>>>> >>>>>> -- >>>>>> Jens Axboe >>>>>> >>>>> >>>>> Here you go: >>>>> >>>>> # git bisect good >>>>> ddc0cc31a2b75b1c7dde870c8867af11fa44db92 is the first bad commit >>>>> commit ddc0cc31a2b75b1c7dde870c8867af11fa44db92 >>>>> Author: Jens Axboe >>>>> Date: Fri Oct 11 10:27:28 2013 -0600 >>>>> >>>>> ppc: disable CPU clock until we can detect whether we have it or n= ot >>>>> >>>>> The child segfault test should catch it, however it does not on >>>>> AIX at least. >>>>> >>>>> Signed-off-by: Jens Axboe >>>> >>>> Hmm, that can=EF=BF=BDt possibly be correct. Would you mind redoing th= e bisection, >>>> just to double check? >>>> >>>> Thanks! >>>> >>>> =EF=BF=BD >>>> Jens Axboe >>> >>> Ok. Let=EF=BF=BDs try this again. Silly user, me. >>> >>> # git bisect good >>> 7cb024f89dbbc314e740885afccd9a05da056cf1 is the first bad commit >>> commit 7cb024f89dbbc314e740885afccd9a05da056cf1 >>> Author: Jens Axboe >>> Date: Wed Nov 6 15:37:35 2013 -0700 >>> >>> solaris: ensure that -D_REENTRANT gets set >>> >>> Apparently some Solaris' require this for threadsafe >>> errno. >>> >>> Signed-off-by: Jens Axboe >>> >>> :100755 100755 b6bfe19aa743fc4104eb587b3ff6068fb5dc67ef ef7be0180258abe= cd4703ebfcf4ed63625d6392f M configure >>> >>> >>> I have the complete git/bisect session in a screen log if you=EF=BF=BDd= like it. >> >> That makes a lot more sense! Can you do: >> >> $ git checkout -f master >> $ git revert 7cb024f89dbbc314e740885afccd9a05da056cf1 >> $ make clean; make >> >> and retest just to be on the safe side? Also, please attach the job file= you are using. >> >> -- >> Jens Axboe > > > Actually, based on the git bisect work, I took out -D_REENTRANT from conf= igure, > and fio-2.1.6 now works as expected. Still want the job file? I do, since the direct part makes little sense to me, if you have=20 direct=3D0 set. --=20 Jens Axboe