From: Jens Axboe <axboe@kernel.dk>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: number_ios is checked on completion, not submission
Date: Tue, 11 Mar 2014 10:14:15 -0600 [thread overview]
Message-ID: <531F3657.9030003@kernel.dk> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B4029548C7B40@G4W3202.americas.hpqcorp.net>
On 03/11/2014 10:08 AM, Elliott, Robert (Server Storage) wrote:
> That patch still exits after 5127 ios.
>
> io_bytes_exceeded is called 5128 times, but it sees td->io_u_queued=0 each time.
Can you check if ->cur_depth or ->io_u_in_flight catches it?
> keep_running makes it to the if (td->o.number_ios) branch one time, and sees number_ios set to 5127 and td->o.number_ios set to 5000 (causing it to return 0 and trigger the end, after 5127 ios).
That's expected. That just controls the outer loop, we want to catch it
in both places.
--
Jens Axboe
next prev parent reply other threads:[~2014-03-11 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 21:12 number_ios is checked on completion, not submission Elliott, Robert (Server Storage)
2014-03-11 15:35 ` Jens Axboe
2014-03-11 16:08 ` Elliott, Robert (Server Storage)
2014-03-11 16:14 ` Jens Axboe [this message]
2014-03-11 16:16 ` Jens Axboe
2014-03-11 16:19 ` Elliott, Robert (Server Storage)
2014-03-11 16:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F3657.9030003@kernel.dk \
--to=axboe@kernel.dk \
--cc=Elliott@hp.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox