From: Jens Axboe <axboe@kernel.dk>
To: Matthew Eaton <m.eaton82@gmail.com>, fio@vger.kernel.org
Subject: Re: Possible bug when setting compression
Date: Fri, 14 Mar 2014 12:26:07 -0600 [thread overview]
Message-ID: <532349BF.4010307@kernel.dk> (raw)
In-Reply-To: <CAF+0mvm1bjy99fbM_jkr9Sp7bbgnQSpr3WkeZ7Zgju9hFdNaSA@mail.gmail.com>
On 03/14/2014 09:52 AM, Matthew Eaton wrote:
> I have been testing iops performance using different compression
> settings and found that setting either zero_buffers or
> buffer_compress_percentage was not enough, I had to also set
> scramble_buffers=0 in order to get the desired compression. But this
> was not the case when setting refill_buffers. I tested with fio 2.1.5
> and fio from git (fio-2.1.6.1-10-g4e59d).
Interesting, it would make sense to simply not scramble if the
compression settings are set. That is what happens with refill_buffers
right now, it has precedence over the scrambling. Or if you give a
buffer pattern, that also disables the scrambling. I'll add the same for
the compression settings.
http://git.kernel.dk/?p=fio.git;a=commit;h=0574c885b82aea0332ab5fa35af84db0f3946726
Care to give it a test spin, just to be on the safe side?
--
Jens Axboe
next prev parent reply other threads:[~2014-03-14 18:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 15:52 Possible bug when setting compression Matthew Eaton
2014-03-14 18:26 ` Jens Axboe [this message]
2014-03-14 19:45 ` Matthew Eaton
2014-03-14 20:09 ` Jens Axboe
2014-03-14 20:23 ` Jens Axboe
2014-03-14 20:53 ` Matthew Eaton
2014-03-14 20:56 ` Jens Axboe
2014-03-14 21:06 ` Matthew Eaton
2014-03-14 21:33 ` Jens Axboe
2014-03-14 22:26 ` Matthew Eaton
2014-03-15 1:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532349BF.4010307@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=m.eaton82@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox