From: Jens Axboe <axboe@kernel.dk>
To: "xan.peng" <xanpeng@gmail.com>
Cc: daniel.gollub@gmail.com, "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Fix a bug of rbd engine when specify invalidate=1 or fadvise_hint=1
Date: Mon, 19 May 2014 19:59:15 -0600 [thread overview]
Message-ID: <537AB6F3.9030303@kernel.dk> (raw)
In-Reply-To: <CA+8ZFng-kGsBJJqNH+ze9TCjpkAMpxTUUeh97U1NKSiFX9K6EQ@mail.gmail.com>
On 2014-05-19 19:32, xan.peng wrote:
> Sure, it's better to have a new type.
> the pull request (https://github.com/axboe/fio/pull/11) is updated in
> the following way:
So thinking more about it, I think it would be a lot cleaner to simply
add an ->invalidate() IO ops hook instead. This retains that this is a
file, special sort of loses that. And it mirrors what we do in other
places, like the very open that rbd hooks in as well.
Committed this:
http://git.kernel.dk/?p=fio.git;a=commit;h=d9b100fc117a963334fb71b8b662be90cd456068
--
Jens Axboe
prev parent reply other threads:[~2014-05-20 1:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 17:38 Fix a bug of rbd engine when specify invalidate=1 or fadvise_hint=1 xan.peng
2014-05-19 19:35 ` Jens Axboe
2014-05-20 1:32 ` xan.peng
2014-05-20 1:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537AB6F3.9030303@kernel.dk \
--to=axboe@kernel.dk \
--cc=daniel.gollub@gmail.com \
--cc=fio@vger.kernel.org \
--cc=xanpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox