From: Jens Axboe <axboe@kernel.dk>
To: George Dowding <gdowding@nutanix.com>, fio@vger.kernel.org
Subject: Re: build from cmake
Date: Mon, 09 Jun 2014 20:04:04 -0600 [thread overview]
Message-ID: <53966794.6080102@kernel.dk> (raw)
In-Reply-To: <CAKO35LNYsNNzcPqJKiiZ12As698qAo1QOs4piZw=-dB_rrHvyg@mail.gmail.com>
On 2014-06-09 14:51, George Dowding wrote:
> I spent a few hours on this. Might save someone else some time.
>
> I'm working in a larger project that uses cmake for its builds. cmake
> supports adding external projects using the ExternalProject_Add
> function.
>
> But, there is some issue in the fio Makefile that causes a problem
> when run from cmake. I could never reproduce it from the command line.
>
> I was able to get the build to happen by changing the implicit rule
> .c.o to use pattern notation. Not sure if this will work in all cases
> or has other side effects.
>
> Without this change, I was getting this error.
>
> make[4]: *** No rule to make target `gettime.o', needed by `fio'. Stop.
It seems to work for me (your change), and it should be correct.
Unfortunately I'm not much of a Makefile expert... So would be nice if
others could chime in.
--
Jens Axboe
prev parent reply other threads:[~2014-06-10 2:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 20:51 build from cmake George Dowding
2014-06-10 2:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53966794.6080102@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gdowding@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox