From: Jens Axboe <axboe@kernel.dk>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Puthikorn Voravootivat <puthik@chromium.org>, fio@vger.kernel.org
Subject: Re: [fio-2.1.9] verify and bssplit do not work together
Date: Mon, 21 Jul 2014 20:52:29 +0200 [thread overview]
Message-ID: <53CD616D.1030908@kernel.dk> (raw)
In-Reply-To: <53CD5EA6.4090706@kernel.dk>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
On 2014-07-21 20:40, Jens Axboe wrote:
>> But looking at the code, it won't be possible to fix, because we can
>> not guarantee to always have 16 4K write contiguous.
>
> As mentioned in the original email, it's a parser fix. verify_interval
> cannot be less than the minimum block size, fio will just have to catch
> that and adjust / error out.
Attach should fix that - untested...
--
Jens Axboe
[-- Attachment #2: x.patch --]
[-- Type: text/x-patch, Size: 425 bytes --]
diff --git a/init.c b/init.c
index cf1d7f938fb3..cf2f82220f72 100644
--- a/init.c
+++ b/init.c
@@ -635,6 +635,9 @@ static int fixup_options(struct thread_data *td)
if (o->max_bs[DDIR_WRITE] != o->min_bs[DDIR_WRITE] &&
!o->verify_interval)
o->verify_interval = o->min_bs[DDIR_WRITE];
+
+ if (o->verify_interval > o->min_bs[DDIR_WRITE])
+ o->verify_interval = o->min_bs[DDIR_WRITE];
}
if (o->pre_read) {
next prev parent reply other threads:[~2014-07-21 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 20:36 [fio-2.1.9] verify and bssplit do not work together Gwendal Grignou
2014-07-18 7:47 ` Jens Axboe
2014-07-21 8:29 ` Jens Axboe
2014-07-21 17:41 ` Gwendal Grignou
2014-07-21 17:49 ` Gwendal Grignou
2014-07-21 18:40 ` Jens Axboe
2014-07-21 18:52 ` Jens Axboe [this message]
2014-07-21 20:24 ` Gwendal Grignou
2014-07-21 20:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CD616D.1030908@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox