From: Jens Axboe <axboe@kernel.dk>
To: Andrey Kuzmin <andrey.v.kuzmin@gmail.com>
Cc: fio@vger.kernel.org
Subject: Re: Pull an external [global] section into an .fio file?
Date: Wed, 30 Jul 2014 14:25:30 +0200 [thread overview]
Message-ID: <53D8E43A.2010102@kernel.dk> (raw)
In-Reply-To: <CANvN+ekK6h90WOb11fTzzYFdi-=hHW5y079n19jT_D2T2ziiOQ@mail.gmail.com>
On 2014-07-29 19:30, Andrey Kuzmin wrote:
> On Mon, Jul 28, 2014 at 11:47 PM, Jens Axboe <axboe@kernel.dk> wrote:
>> On 2014-07-28 19:42, Andrey Kuzmin wrote:
>>>
>>> When dealing with a growing number of fio test scripts, copy/pasting
>>> global section becomes error-prone and cumbersome. Is it possible (or
>>> how much effort would it be to add such a feature) to pull a named set
>>> of global settings into the .fio file?
>>
>>
>> Not currently possible, but I can see it being a useful feature. I'll add it
>> to the list. Something ala
>>
>> fio --shared globals.fio actual-job.fio
>>
>> I added something similar back in April for command line jobs, where you can
>> now do
>>
>> fio --some-setting=1 --other-setting=2 actual-job.fio
>>
>> and have that those settings be part of the global namespace.
>
> My take would be to focus on the .fio file rather than on the
> command-line, as job files lend itself very well to the management and
> version control found in the test suite settings. Adding support for
> the include filenames... directive in .fio files would make the most
> sense to me in this respect.
Yes, an include directive would be useful. After writing the previous
email I thought a bit more about it, and decided that the way to go
would not be an extra --shared or --include, but rather just have that
be the default behavior if a job file only had a global section. But we
could still allow that, and add an include directive in the parser.
--
Jens Axboe
prev parent reply other threads:[~2014-07-30 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 17:42 Pull an external [global] section into an .fio file? Andrey Kuzmin
2014-07-28 18:21 ` Kulkarni, Vasu
2014-07-28 18:35 ` Carl Zwanzig
2014-07-29 5:28 ` Christian Ehrhardt
2014-07-29 6:47 ` Jens Axboe
2014-07-29 17:30 ` Andrey Kuzmin
2014-07-30 12:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D8E43A.2010102@kernel.dk \
--to=axboe@kernel.dk \
--cc=andrey.v.kuzmin@gmail.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox