Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>,
	"fio@vger.kernel.org" <fio@vger.kernel.org>
Cc: Sitsofe Wheeler <sitsofe@gmail.com>, Jon Tango <cheerios123@outlook.com>
Subject: Re: linux /dev and normal files
Date: Thu, 02 Oct 2014 12:32:06 -0600	[thread overview]
Message-ID: <542D9A26.6060204@kernel.dk> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B402958CCAA76@G4W3202.americas.hpqcorp.net>

On 10/02/2014 12:21 PM, Elliott, Robert (Server Storage) wrote:
>>>> It might be better to continue to attempt to run the
>>>> other jobs.
>>>
>>> We should just go for the simpler create/nocreate solution, I prefer
>>> that. This is too involved, and it's hard to get all the cases right
>>> since there are a bunch of different ways that files are added. Which
>>> was why this patch only focused on filename=, since that is the one that
>>> is the most interesting. But it still isn't pretty. If we add the
>>> allow_file_create option, it's basically a two-liner change in a few
>>> places to not use O_CREAT.
>>
>> That took roughly 4 minutes... Does this work? Set allow_file_create=0
>> to disallow creating new files.
>>
> 
> Mostly.  
> 
> With no size= setting or size=xx%, the error messages it prints are 
> about the lack of size, not the fact that file creation is disallowed.
> It does proceed to run the jobs that have valid filenames.
> 
> drive_af: you need to specify size=
> fio: pid=0, err=22/file:filesetup.c:822, func=total_file_size, error=Invalid argument
> drive_af: you need to specify size=
> fio: pid=0, err=22/file:filesetup.c:822, func=total_file_size, error=Invalid argument
> ...
> drive_ag: you need to specify size=
> fio: pid=0, err=22/file:filesetup.c:822, func=total_file_size, error=Invalid argument
> Jobs: 168 (f=168): [r(168),X(24)] [0.0% done] [2449MB/0KB/0KB /s] [627K/0/0 iops] [eta 02d:11h:58m:33s]

Fio always does this, if the file does not exist and no size is given.
The reason is that it doesn't know what size to create. But we can
augment that a little bit if allow_file_create == 0, since the size
setting would not change that.

> With size=xxm (a fixed size), it prints complaints about O_DIRECT.
> It does proceed to run the jobs that have valid filenames.
> 
> fio: looks like your file system does not support direct=1/buffered=0
> fio: destination does not support O_DIRECT
> fio: pid=21834, err=22/file:filesetup.c:613, func=open(/dev/sdaf), error=Invalid argument
> fio: looks like your file system does not support direct=1/buffered=0
> fio: destination does not support O_DIRECT
> fio: pid=21846, err=22/file:filesetup.c:613, func=open(/dev/sdag), error=Invalid argument
> fio: looks like your file system does not support direct=1/buffered=0
> fio: destination does not support O_DIRECT
> ...
> fio: pid=21856, err=22/file:filesetup.c:613, func=open(/dev/sdag), error=Invalid argument
> Jobs: 168 (f=168): [r(168),X(24)] [0.0% done] [2449MB/0KB/0KB /s] [627K/0/0 iops] [eta 02d:11h:58m:50s]

OK, let me test that, will spin a new one.

-- 
Jens Axboe



  reply	other threads:[~2014-10-02 18:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 23:49 linux /dev and normal files Elliott, Robert (Server Storage)
2014-10-01  1:02 ` Jens Axboe
2014-10-01  1:12   ` Elliott, Robert (Server Storage)
2014-10-01  1:17     ` Jens Axboe
2014-10-01  3:43       ` Jens Axboe
2014-10-01  7:36         ` Sitsofe Wheeler
2014-10-01 14:20           ` Jens Axboe
2014-10-01 14:31             ` Elliott, Robert (Server Storage)
2014-10-01 23:52         ` Elliott, Robert (Server Storage)
2014-10-02  0:58           ` Jens Axboe
2014-10-02  1:03             ` Jens Axboe
2014-10-02 18:21               ` Elliott, Robert (Server Storage)
2014-10-02 18:32                 ` Jens Axboe [this message]
2014-10-02 18:41                   ` Jens Axboe
2015-04-03 18:13                   ` Elliott, Robert (Server Storage)
2015-04-03 18:24                     ` Jens Axboe
2015-05-12 15:32                       ` Jens Axboe
2015-05-12 16:34                         ` Elliott, Robert (Server Storage)
2015-05-12 17:56                           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542D9A26.6060204@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Elliott@hp.com \
    --cc=cheerios123@outlook.com \
    --cc=fio@vger.kernel.org \
    --cc=sitsofe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox