From: Jens Axboe <axboe@kernel.dk>
To: "Sébastien Bouchex Bellomié" <sbouchex@infovista.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: anonymous mmap issue on solaris
Date: Thu, 30 Oct 2014 08:40:42 -0600 [thread overview]
Message-ID: <54524DEA.8010109@kernel.dk> (raw)
In-Reply-To: <5416a70b91da426280173bb27a43f0e7@DB4PR03MB572.eurprd03.prod.outlook.com>
On 2014-10-30 08:06, S�bastien Bouchex Bellomi� wrote:
> Hi,
>
> An issue on solaris :
>
> Anonymous mmap must have a fd set to -1 in order to work (on linux, it is ignored), in alloc_mem_mmap, the fd is set to 1
>
> [.]
> static int alloc_mem_mmap(struct thread_data *td, size_t total_mem)
> {
> int flags = 0;
>
> td->mmapfd = 1;
>
> if (td->o.mem_type == MEM_MMAPHUGE) {
> [.]
>
> Changing it to -1 makes the code working fine.
That actually just looks like a typo, it makes no sense for this to be
'1'... I'll fix it, thanks for finding it!
--
Jens Axboe
prev parent reply other threads:[~2014-10-30 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 14:06 anonymous mmap issue on solaris Sébastien Bouchex Bellomié
2014-10-30 14:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54524DEA.8010109@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=sbouchex@infovista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox