From: Jens Axboe <axboe@kernel.dk>
To: Chris Wilson <Chris.Wilson@nutanix.com>, fio@vger.kernel.org
Subject: Re: Scramble buffers not set by default unless set explicitly
Date: Sat, 20 Dec 2014 14:45:10 -0700 [thread overview]
Message-ID: <5495EDE6.7040901@kernel.dk> (raw)
In-Reply-To: <58BC9DC1-E3EE-4B45-9ED7-0B5506045A14@nutanix.com>
On 12/20/2014 09:32 AM, Chris Wilson wrote:
> A change (1bf2498d311155bc4eb43edb4e6d3a04845d94c5) to make scramble buffers easier to understand appears to have made scramble buffers not the default behavior by accident. The logic would always evaluate such that scramble buffers is not used unless set explicitly.
>
> I think the following little patch changes the logic to what was intended.
Oops, yes that was unintended. Your fix doesn't work for zero enabled
and scramble not set, however. I've checked in a two prong approach:
http://git.kernel.dk/?p=fio.git;a=commit;h=b04f590551050b23768a3969d47371d363aa8745
please let me know if that work as intended for you.
--
Jens Axboe
prev parent reply other threads:[~2014-12-20 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 16:32 Scramble buffers not set by default unless set explicitly Chris Wilson
2014-12-20 21:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5495EDE6.7040901@kernel.dk \
--to=axboe@kernel.dk \
--cc=Chris.Wilson@nutanix.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox