From: Jens Axboe <axboe@fb.com>
To: Ming Lei <ming.lei@canonical.com>, fio@vger.kernel.org
Cc: Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH] axmap: fix deadlock
Date: Sat, 3 Jan 2015 11:11:51 -0700 [thread overview]
Message-ID: <54A830E7.5080509@fb.com> (raw)
In-Reply-To: <1420294869-3830-1-git-send-email-ming.lei@canonical.com>
On 01/03/2015 07:21 AM, Ming Lei wrote:
> axmap_first_free() is always called with axmap->lock held,
> so needn't to acquire the lock inside the function.
>
> The deadlock is introduced in commit 12bde3697fc230d7a(axmap:
> ensure we lock down the maps for shared access).
>
> Given axmap_first_free() is only called inside lib/axmap.c,
> this patch declares the function as static. In the future,
> if external users need the function, axmap lock can be
> considered at that time.
Thanks Ming, applied.
--
Jens Axboe
next prev parent reply other threads:[~2015-01-03 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 14:21 [PATCH] axmap: fix deadlock Ming Lei
2015-01-03 14:37 ` Sedat Dilek
2015-01-03 18:11 ` Jens Axboe [this message]
2015-01-03 19:39 ` Sedat Dilek
2015-01-03 20:13 ` Jens Axboe
2015-01-03 23:51 ` Sedat Dilek
2015-01-04 2:48 ` Jens Axboe
2015-01-04 8:09 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A830E7.5080509@fb.com \
--to=axboe@fb.com \
--cc=fio@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox