From: Jens Axboe <axboe@kernel.dk>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] verify: Fix latency log for verify commands.
Date: Mon, 09 Feb 2015 08:16:57 -0700 [thread overview]
Message-ID: <54D8CF69.5070304@kernel.dk> (raw)
In-Reply-To: <1423454000-7730-1-git-send-email-gwendal@chromium.org>
On 02/08/2015 08:53 PM, Gwendal Grignou wrote:
> When commands when requeued for the verify operation,
> their start time was not reset, resulting in bogus latency graphs.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
> backend.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/backend.c b/backend.c
> index 7ec8d2a..0f6e425 100644
> --- a/backend.c
> +++ b/backend.c
> @@ -565,6 +565,8 @@ static void do_verify(struct thread_data *td, uint64_t verify_bytes)
> io_u->end_io = verify_io_u;
>
> ddir = io_u->ddir;
> + if (!td->o.disable_slat)
> + fio_gettime(&io_u->start_time, NULL);
>
> ret = td_io_queue(td, io_u);
> switch (ret) {
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2015-02-09 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 3:53 [PATCH] verify: Fix latency log for verify commands Gwendal Grignou
2015-02-09 9:39 ` Andrey Kuzmin
2015-02-09 15:17 ` Jens Axboe
2015-02-09 15:25 ` Andrey Kuzmin
2015-02-09 15:27 ` Jens Axboe
2015-02-09 15:59 ` Andrey Kuzmin
2015-02-09 15:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D8CF69.5070304@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gwendal@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox