Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Erwan Velu <erwan@enovance.com>
To: Jens Axboe <axboe@kernel.dk>, fio@vger.kernel.org
Subject: Re: Potential leaks & errors on current trunk
Date: Thu, 19 Feb 2015 13:17:44 +0100	[thread overview]
Message-ID: <54E5D468.1070200@enovance.com> (raw)
In-Reply-To: <54E4DBB7.7080705@kernel.dk>


Le 18/02/2015 19:36, Jens Axboe a écrit :
>
>> http://git.kernel.dk/?p=fio.git;a=blob;f=iolog.c;h=99f8bc18d8694cca0c141c51d116aced1b4130f2;hb=HEAD#l863 
>>
>>
>> In that function, if we do return 1 we do leak ic.buf, we shall free it
>> before the return
>
> Yep, there's a potential leak or two there, should be fixed up.
>
>> http://git.kernel.dk/?p=fio.git;a=blob;f=lib/axmap.c;h=164300f254014b10ed6e04e3e06b7263aa917aac;hb=HEAD#l127 
>>
>>
>> Here, we surely miss the free of the axmap. We did free its internal
>> structure but not axmap itself.
>
> Yes, that should free 'axmap' too of course.
>

Hey Jens,

I don't know your workflow : do you accept pull request directly on github ?

At least, please find the two commits for that issues in my repo : 
https://github.com/enovance/fio/tree/erwan/memory-leak

Cheers,

-- 
Erwan Velu
eNovance from Redhat



  parent reply	other threads:[~2015-02-19 12:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 15:00 Potential leaks & errors on current trunk Erwan Velu
2015-02-18 18:36 ` Jens Axboe
2015-02-18 19:54   ` Andrey Kuzmin
2015-02-18 20:28     ` Jens Axboe
2015-02-19 12:17   ` Erwan Velu [this message]
2015-02-19 16:48     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E5D468.1070200@enovance.com \
    --to=erwan@enovance.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox