From: Jens Axboe <axboe@kernel.dk>
To: Mark Nelson <mark.a.nelson@gmail.com>,
Ben England <bengland@redhat.com>,
fio@vger.kernel.org
Subject: Re: suggestion: patch to make per-thread IOPS more accurate
Date: Thu, 26 Feb 2015 16:20:04 -0700 [thread overview]
Message-ID: <54EFAA24.8070603@kernel.dk> (raw)
In-Reply-To: <54EF8E70.1000504@gmail.com>
On 02/26/2015 02:21 PM, Mark Nelson wrote:
> Hi Ben,
>
> I confess that I'm not using JSON output myself, but I think this would
> be really beneficial when there are a lot of clients (like VMs).
>
> Jens, would this be an acceptable change? I think I'd appreciate this
> if I switch over to using the JSON output.
I like the change, my only worry is that it'll break somebody's
parsing... So from that end, perhaps it'd be better to add a new field
instead of reusing the 'iops' field to dump it.
Maybe I'm just being overly cautious here, feel free to tell me I'm wrong.
--
Jens Axboe
next prev parent reply other threads:[~2015-02-26 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <596106035.8980737.1421443175599.JavaMail.zimbra@redhat.com>
[not found] ` <54B982D7.1070503@kernel.dk>
[not found] ` <177931222.1695665.1422463951931.JavaMail.zimbra@redhat.com>
2015-02-15 22:27 ` suggestion for fio --client to remove garbled output Ben England
[not found] ` <159806365.11854527.1422052704407.JavaMail.zimbra@redhat.com>
2015-02-15 22:33 ` suggestion: patch to make per-thread IOPS more accurate Ben England
2015-02-26 21:21 ` Mark Nelson
2015-02-26 23:20 ` Jens Axboe [this message]
2015-02-27 4:14 ` Andrew Theurer
2015-02-27 15:21 ` Jens Axboe
[not found] <2137206709.6359691.1424464503833.JavaMail.zimbra@redhat.com>
2015-02-20 20:38 ` Andrew Theurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EFAA24.8070603@kernel.dk \
--to=axboe@kernel.dk \
--cc=bengland@redhat.com \
--cc=fio@vger.kernel.org \
--cc=mark.a.nelson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox