From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <554BD3CE.6090609@kernel.dk> Date: Thu, 07 May 2015 15:06:22 -0600 From: Jens Axboe MIME-Version: 1.0 Subject: Re: [PATCH] Add Windows ctime_r implementation and empty ioctl.h header References: <554ADC87.2070605@cran.org.uk> <554B99DD.2000902@kernel.dk> <554BD378.70209@cran.org.uk> In-Reply-To: <554BD378.70209@cran.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Bruce Cran , "fio@vger.kernel.org" List-ID: On 05/07/2015 03:04 PM, Bruce Cran wrote: > On 5/7/2015 10:59 AM, Jens Axboe wrote: >> Added. Side note - your email consistently ends up in my gmail spam, >> for some reason... > > Ugh, it's because DMARC doesn't work through mailing lists without > jumping through hoops. I'll see if I can disable it for specified > destinations. This one got through, but probably because it's a reply.. >> What are the linker errors? I'm guessing you need to check and add >> your OS dependencies to T_OBJS in the Makefile, when targetos is Windows. > > Got it - I'd forgotten that the Makefile is still checked in and it's > not generated by the configure script! > I've attached a patch which should make the build work a lot better on > Windows. Thanks, added. -- Jens Axboe