From: Jens Axboe <axboe@kernel.dk>
To: Bruce Cran <bruce@cran.org.uk>, fio@vger.kernel.org
Subject: Re: fio newer than 2.2.12 segfaults on examples/tiobench-example.fio
Date: Wed, 20 Jan 2016 21:54:20 -0700 [thread overview]
Message-ID: <56A0647C.6030607@kernel.dk> (raw)
In-Reply-To: <56A063DD.8040502@kernel.dk>
On 01/20/2016 09:51 PM, Jens Axboe wrote:
> On 01/20/2016 09:43 PM, Bruce Cran wrote:
>> On 01/20/2016 09:33 PM, Jens Axboe wrote:
>>> Can you try and revert commit 09400a60042 and see if that fixes it?
>>
>> Yes, that does fix it.
>
> So it sounds like a double unlock issue, as per the bug report you also
> referenced.
>
> Can you checkout out the 2.4 release again, and see if there are cases
> where pthread_cond_timedwait() returns with the mutex unlocked already?
> The man page states:
>
> "Upon successful return, the mutex shall have been locked and shall be
> owned by the calling thread."
>
> but it's not clear if that's not the case for error return (eg timed out).
Duh, nevermind:
http://git.kernel.dk/cgit/fio/commit/?id=42e833fa08803ccea6c99df353398a7423845c51
--
Jens Axboe
next prev parent reply other threads:[~2016-01-21 4:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 14:03 fio newer than 2.2.12 segfaults on examples/tiobench-example.fio Bruce Cran
2016-01-18 21:57 ` Jens Axboe
2016-01-21 4:30 ` Bruce Cran
2016-01-21 4:33 ` Jens Axboe
2016-01-21 4:43 ` Bruce Cran
2016-01-21 4:51 ` Jens Axboe
2016-01-21 4:54 ` Jens Axboe [this message]
2016-01-21 4:38 ` Bruce Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0647C.6030607@kernel.dk \
--to=axboe@kernel.dk \
--cc=bruce@cran.org.uk \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox