From: Bruce Cran <bruce@cran.org.uk>
To: Jens Axboe <axboe@kernel.dk>,
Jeff Furlong <jeff.furlong@hgst.com>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: Windows Make Broken
Date: Fri, 22 Jan 2016 15:21:53 -0700 [thread overview]
Message-ID: <56A2AB81.60107@cran.org.uk> (raw)
In-Reply-To: <56A2A940.9000105@kernel.dk>
On 1/22/16 3:12 PM, Jens Axboe wrote:
> I think you earlier added it in the cygwin section. We need to kill that
> one, not the generic one, since that would fail on systems not providing
> strcasestr().
>
> http://git.kernel.dk/cgit/fio/commit/?id=ada83043abcb94dde7c603ce60ae8de9693a022f
There's one other fix in my patch that would be good to be committed:
Cygwin doesn't define rand_r since it's not in C99
(https://cygwin.com/ml/cygwin/2009-05/msg00432.html). I've instead
changed os-windows.h to avoid the compiler warnings.
--
Bruce
next prev parent reply other threads:[~2016-01-22 22:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 21:43 Windows Make Broken Jeff Furlong
2016-01-21 21:53 ` Bruce Cran
2016-01-22 4:18 ` Jens Axboe
2016-01-22 13:30 ` Bruce Cran
2016-01-22 18:16 ` Bruce Cran
2016-01-22 18:50 ` Jens Axboe
2016-01-22 22:02 ` Bruce Cran
2016-01-22 22:12 ` Jens Axboe
2016-01-22 22:18 ` Bruce Cran
2016-01-22 22:21 ` Bruce Cran [this message]
2016-01-22 22:25 ` Jens Axboe
2016-01-22 22:37 ` Bruce Cran
2016-01-22 22:40 ` Jens Axboe
2016-01-22 22:58 ` Jeff Furlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A2AB81.60107@cran.org.uk \
--to=bruce@cran.org.uk \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jeff.furlong@hgst.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox