From: Jens Axboe <axboe@kernel.dk>
To: Ben England <bengland@redhat.com>
Cc: fio@vger.kernel.org, Tim Wilkinson <twilkins@redhat.com>,
Andrew Theurer <atheurer@redhat.com>,
John Harrigan <jharriga@redhat.com>
Subject: Re: problem with fio --client and latency logs
Date: Fri, 27 May 2016 13:33:14 -0600 [thread overview]
Message-ID: <5748A0FA.6060607@kernel.dk> (raw)
In-Reply-To: <991224849.66548485.1464377361166.JavaMail.zimbra@redhat.com>
On 05/27/2016 01:29 PM, Ben England wrote:
> it passes my simple test, I'll try it out in the large next, thx Jens.
Super, let me know if you see issues. The difference in your two tests
is that fio will compress the log on the server side, to reduce the
amount of data we have to transfer. The bug was on the compression side,
so the client only got the first chunk of partial data. That meant that
we'd have the correct number of entries in the log, but the majority of
it would be zeroes...
> This is the last commit I saw in master branch upstream just now after
> pulling into my clone:
>
> commit e35fb4c43ecc5b9d35cb5d980e811d3408fc5a4e
> Author: Jens Axboe <axboe@fb.com>
> Date: Fri May 27 11:01:15 2016 -0600
>
> server: ensure that we flush compressed logs correctly
>
> Do chunkwise block compression, and flush at the end, adding more space
> as needed.
>
> Signed-off-by: Jens Axboe <axboe@fb.com>
Yes, that's the fix in question.
> When I run fio -h after rebuild, it shows I'm on this commit because
> last 4 hex digits of version "fio-2.11-5-ge35f" are first 4 digits of
> git commit ID, which is reassuring.
That's why I added it :-)
Most people never include the version of fio when they report a bug, at
least we'll have the version if they paste the fio output.
--
Jens Axboe
prev parent reply other threads:[~2016-05-27 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <671811755.66182002.1464284748641.JavaMail.zimbra@redhat.com>
2016-05-26 19:11 ` problem with fio --client and latency logs Ben England
2016-05-27 14:43 ` Jens Axboe
2016-05-27 17:02 ` Jens Axboe
2016-05-27 19:29 ` Ben England
2016-05-27 19:33 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5748A0FA.6060607@kernel.dk \
--to=axboe@kernel.dk \
--cc=atheurer@redhat.com \
--cc=bengland@redhat.com \
--cc=fio@vger.kernel.org \
--cc=jharriga@redhat.com \
--cc=twilkins@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox