Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	Ankit Kumar <ankit.kumar@samsung.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
	"krish.reddy@samsung.com" <krish.reddy@samsung.com>,
	"prakash.v@samsung.com" <prakash.v@samsung.com>
Subject: Re: [PATCH 0/2] v2: ZBD fix with random zone index logic and missing documentation
Date: Wed, 4 Aug 2021 07:25:01 -0600	[thread overview]
Message-ID: <5d93c040-c57c-502c-4262-8526d4d2867e@kernel.dk> (raw)
In-Reply-To: <20210804110731.7yqxy6k7dr6evrrg@shindev>

On 8/4/21 5:07 AM, Shinichiro Kawasaki wrote:
> On Aug 04, 2021 / 14:54, Ankit Kumar wrote:
>> v1 -> v2
>>
>>  - Addressed the commit message review comments for both the patches
>>
>> Ankit Kumar (2):
>>   HOWTO: Add missing documentation for job_max_open_zones
>>   zbd: Improve random zone index generation logic
> 
> Ankit, when I commented the v1 patches, I overlooked that your commit messages
> do not include your Signed-off-by tags. Many of the fio commits have the tags.
> To clarify who contributed, I suggest to add it to the two patches.

Indeed, please always add those.

-- 
Jens Axboe



      reply	other threads:[~2021-08-04 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210804092848epcas5p43713e1728116d2ea38c910a2b8991c42@epcas5p4.samsung.com>
2021-08-04  9:24 ` [PATCH 0/2] v2: ZBD fix with random zone index logic and missing documentation Ankit Kumar
2021-08-04  9:24   ` [PATCH 1/2] HOWTO: Add missing documentation for job_max_open_zones Ankit Kumar
2021-08-04  9:24   ` [PATCH 2/2] zbd: Improve random zone index generation logic Ankit Kumar
2021-08-04 11:07   ` [PATCH 0/2] v2: ZBD fix with random zone index logic and missing documentation Shinichiro Kawasaki
2021-08-04 13:25     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d93c040-c57c-502c-4262-8526d4d2867e@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=ankit.kumar@samsung.com \
    --cc=fio@vger.kernel.org \
    --cc=krish.reddy@samsung.com \
    --cc=prakash.v@samsung.com \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox