From: Jens Axboe <axboe@kernel.dk>
To: "Su, Friendy" <Friendy.Su@sony.com>, Sitsofe Wheeler <sitsofe@gmail.com>
Cc: fio <fio@vger.kernel.org>,
"Kobayashi, Kento (Sony)" <Kento.A.Kobayashi@sony.com>
Subject: Re: [PATCH] engines: add engine for file stat
Date: Wed, 22 Jan 2020 08:32:25 -0700 [thread overview]
Message-ID: <613a7d9e-4a0f-1b89-128d-5da7cf4390e2@kernel.dk> (raw)
In-Reply-To: <HK0PR04MB23886E2661C532F057030540FD0C0@HK0PR04MB2388.apcprd04.prod.outlook.com>
On 1/21/20 8:07 PM, Su, Friendy wrote:
> This engine is to measure performance of accessing file's meta data.
> This is for the actual access pattern which does not do real IO, but
> just look up the file and get file's attribute.
Applied, just one minor fixup:
> + if (f->filetype != FIO_TYPE_FILE) {
> + log_err("fio: only files are supported fallocate \n");
> + return 1;
> + }
Not sure where this fallocate came from, too much copy paste perhaps?
--
Jens Axboe
next prev parent reply other threads:[~2020-01-22 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 10:08 [PATCH] engines: add engine for file stat Friendy.Su
2019-12-17 10:28 ` Su, Friendy
2019-12-17 14:04 ` Sitsofe Wheeler
2019-12-19 10:19 ` Su, Friendy
2019-12-29 21:23 ` Sitsofe Wheeler
2019-12-29 23:20 ` Jens Axboe
2020-01-08 9:32 ` Su, Friendy
2020-01-21 10:09 ` Su, Friendy
2020-01-21 15:26 ` Jens Axboe
2020-01-22 3:05 ` Su, Friendy
2020-01-22 3:07 ` Su, Friendy
2020-01-22 15:32 ` Jens Axboe [this message]
2020-02-02 8:18 ` Su, Friendy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613a7d9e-4a0f-1b89-128d-5da7cf4390e2@kernel.dk \
--to=axboe@kernel.dk \
--cc=Friendy.Su@sony.com \
--cc=Kento.A.Kobayashi@sony.com \
--cc=fio@vger.kernel.org \
--cc=sitsofe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox