From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 26 Feb 2015 23:14:15 -0500 (EST) From: Andrew Theurer Message-ID: <618699956.9909382.1425010455755.JavaMail.zimbra@redhat.com> In-Reply-To: <54EFAA24.8070603@kernel.dk> References: <596106035.8980737.1421443175599.JavaMail.zimbra@redhat.com> <54B982D7.1070503@kernel.dk> <159806365.11854527.1422052704407.JavaMail.zimbra@redhat.com> <1745095866.10478940.1424039625224.JavaMail.zimbra@redhat.com> <54EF8E70.1000504@gmail.com> <54EFAA24.8070603@kernel.dk> Subject: Re: suggestion: patch to make per-thread IOPS more accurate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Jens Axboe Cc: Mark Nelson , Ben England , fio@vger.kernel.org List-ID: ----- Original Message ----- > From: "Jens Axboe" > To: "Mark Nelson" , "Ben England" , fio@vger.kernel.org > Sent: Thursday, February 26, 2015 5:20:04 PM > Subject: Re: suggestion: patch to make per-thread IOPS more accurate > > On 02/26/2015 02:21 PM, Mark Nelson wrote: > > Hi Ben, > > > > I confess that I'm not using JSON output myself, but I think this would > > be really beneficial when there are a lot of clients (like VMs). > > > > Jens, would this be an acceptable change? I think I'd appreciate this > > if I switch over to using the JSON output. > > I like the change, my only worry is that it'll break somebody's > parsing... So from that end, perhaps it'd be better to add a new field > instead of reusing the 'iops' field to dump it. > > Maybe I'm just being overly cautious here, feel free to tell me I'm wrong. Since this is for the json data, I don't think the parsing would be an issue. I have at least tried reading this data with parl::JSON with this patch, and there have been no issues. -Andrew > > -- > Jens Axboe > > -- > To unsubscribe from this list: send the line "unsubscribe fio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >