Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
	Andreas Herrmann <aherrmann@suse.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH 1/4] stat: Print one-line iops stat
Date: Mon, 26 Jun 2017 08:52:01 -0600	[thread overview]
Message-ID: <67ebce2a-bdcf-90d2-bd43-0a353cc45ec2@fb.com> (raw)
In-Reply-To: <AT5PR84MB0082C10FAD4DA42F5F7B1295ABDF0@AT5PR84MB0082.NAMPRD84.PROD.OUTLOOK.COM>

On 06/26/2017 08:30 AM, Elliott, Robert (Persistent Memory) wrote:
> 
> 
>> -----Original Message-----
>> From: fio-owner@vger.kernel.org [mailto:fio-owner@vger.kernel.org] On
>> Behalf Of Andreas Herrmann
>> Sent: Friday, June 23, 2017 5:28 PM
>> To: Jens Axboe <axboe@fb.com>
>> Cc: fio@vger.kernel.org
>> Subject: [PATCH 1/4] stat: Print one-line iops stat
>>
>> This adds basic iops statistics (likewise to what we already have for
>> bandwidth) to normal and json fio output. Example for normal output:
>>
>>    bw (  KiB/s): min=42192, max=162068, per=0.10%, avg=93236.21,
>> stdev=22180.02
>>    iops : min=21090, max=81020, avg=46606.84, stdev=11088.40
>>     lat (usec) : 2=55.13%, 4=21.11%, 10=0.36%, 20=0.03%, 50=23.14%
> ...
>> +		log_buf(out, "   iops : min=%5llu, max=%5llu, avg=%5.02f, "
>> +			"stdev=%5.02f\n", min, max, mean, dev);
> 
> Seven more spaces are needed to line up the : characters in all the rows.

Good catch, I fixed that up.

-- 
Jens Axboe


  reply	other threads:[~2017-06-26 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 22:27 [PATCH v4 0/4] stat: Modify info for bw and add iops stats Andreas Herrmann
2017-06-23 22:27 ` [PATCH 1/4] stat: Print one-line iops stat Andreas Herrmann
2017-06-26 14:30   ` Elliott, Robert (Persistent Memory)
2017-06-26 14:52     ` Jens Axboe [this message]
2017-06-23 22:27 ` [PATCH 2/4] stat: Print number of samples in bw and iops stats Andreas Herrmann
2017-06-23 22:27 ` [PATCH 3/4] stat: Merge show_thread_status_terse_* functions Andreas Herrmann
2017-06-23 22:27 ` [PATCH 4/4] stat: Add iops stat and sample number information to terse format Andreas Herrmann
2017-06-23 22:31 ` [PATCH v4 0/4] stat: Modify info for bw and add iops stats Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2017-06-23 17:42 [PATCH v3 " Andreas Herrmann
2017-06-23 17:42 ` [PATCH 1/4] stat: Print one-line iops stat Andreas Herrmann
2017-06-23 18:26   ` Jens Axboe
2017-06-23 19:47     ` Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67ebce2a-bdcf-90d2-bd43-0a353cc45ec2@fb.com \
    --to=axboe@fb.com \
    --cc=aherrmann@suse.com \
    --cc=elliott@hpe.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox