From: Damien Le Moal <dlemoal@kernel.org>
To: Jan Kara <jack@suse.cz>, fio@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>, Vincent Fu <vincentfu@gmail.com>
Subject: Re: [PATCH 5/5] Add option to specify ramp period by amount of IO
Date: Thu, 18 Dec 2025 08:03:36 +0900 [thread overview]
Message-ID: <7dab8aa5-3ff1-4031-8c9f-30c2bc8cc050@kernel.org> (raw)
In-Reply-To: <20251217161722.6357-5-jack@suse.cz>
On 12/18/25 01:17, Jan Kara wrote:
> In some cases the ramp up period is not easy to define by amount of
> time. This is for example a case of buffered writes measurement where we
> want to start measuring only once dirty throttling kicks in. The time
> until dirty throttling kicks in depends on dirty limit (easy to figure
> out) and speed of writes to the page cache (difficult to know in
> advance). Add option ramp_size which determines the ramp up period by
> the amount of IO written (either by each job or by each group when group
> reporting is enabled).
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> HOWTO.rst | 7 +++++++
> fio.1 | 6 ++++++
> options.c | 11 +++++++++++
> thread_options.h | 2 ++
> time.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++--
> 5 files changed, 74 insertions(+), 2 deletions(-)
>
> diff --git a/HOWTO.rst b/HOWTO.rst
> index 9f55a73bde05..49ebae6275a6 100644
> --- a/HOWTO.rst
> +++ b/HOWTO.rst
> @@ -715,6 +715,13 @@ Time related parameters
> :option:`runtime` is specified. When the unit is omitted, the value is
> given in seconds.
>
> +.. option:: ramp_size=size
> +
> + If set, fio will wait until the workload does given amount of IO before
> + logging any performance numbers. Similar considerations apply as for
> + ``ramp_time`` option. When the unit is omitted, the value is given in
> + megabytes.
Hmm... It may be less confusing/easier to use the regular fio "int" parameter
type here, which takes all the kilo, mega etc suffixes. This means that the
default without any suffix would be bytes, not megabytes.
Other than this, this looks good to me, and indeed super useful when testing
file systems with buffered I/Os so that the initial super fast buffering spike
is easily not accounted for.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-12-17 23:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 16:17 [PATCH 0/5] Add support for specifying ramp up period by amount of IO Jan Kara
2025-12-17 16:17 ` [PATCH 1/5] time: rename in_ramp_time() and ramp_time_over() Jan Kara
2025-12-17 22:52 ` Damien Le Moal
2025-12-19 3:53 ` fiotestbot
2025-12-17 16:17 ` [PATCH 2/5] td: Initialize ramp_period_over based on options Jan Kara
2025-12-17 22:53 ` Damien Le Moal
2025-12-17 16:17 ` [PATCH 3/5] eta: Use in_ramp_period() instead of opencoding it Jan Kara
2025-12-17 22:55 ` Damien Le Moal
2025-12-17 16:17 ` [PATCH 4/5] time: Evaluate ramp up condition once per second Jan Kara
2025-12-17 22:58 ` Damien Le Moal
2025-12-17 16:17 ` [PATCH 5/5] Add option to specify ramp period by amount of IO Jan Kara
2025-12-17 22:56 ` Jens Axboe
2025-12-18 17:18 ` Jan Kara
2025-12-17 23:03 ` Damien Le Moal [this message]
2025-12-18 16:31 ` Jan Kara
2025-12-19 8:12 ` Damien Le Moal
2025-12-19 13:10 ` Jan Kara
2025-12-18 15:19 ` Vincent Fu
2025-12-18 17:18 ` Jan Kara
2025-12-18 21:42 ` Vincent Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dab8aa5-3ff1-4031-8c9f-30c2bc8cc050@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=jack@suse.cz \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox