From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <damien.lemoal@wdc.com>, fio@vger.kernel.org
Subject: Re: [PATCH 1/2] eta: Avoid adjustements to a negative value
Date: Wed, 26 Sep 2018 08:26:25 -0600 [thread overview]
Message-ID: <8cecc91e-2e15-4d74-c66a-01f9d72e04bf@kernel.dk> (raw)
In-Reply-To: <20180926064210.2537-1-damien.lemoal@wdc.com>
On 9/26/18 12:42 AM, Damien Le Moal wrote:
> In the case of zonemode=strided job with both zone_size and zone_skip
> specified, thread_eta() calculates the upper bound of the number of
> zones that will be processed, including skipped bytes between zones
> (zone_skip). Adjusting bytes_total (i.e. total_io_size) by substracting
> this number of zones times the amount of skipped bytes can result in
> a negative value for bytes_total (a large number of bytes) when for
> example the job operates on an entire disk with a capacity that is not
> divisible exactly by zone_size+zone_skip or if the options --size is
> used to limit the I/O range. In such case, use the lower bound of the
> number of zones to obtain a better approximation of the job eta.
>
> Additionnally, if --io_size was specified, bytes_total will indicate
> this exact value, so adjusting that value for zonemode != none is not
> necessary.
Applied 1-2, thanks Damien.
--
Jens Axboe
prev parent reply other threads:[~2018-09-26 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 6:42 [PATCH 1/2] eta: Avoid adjustements to a negative value Damien Le Moal
2018-09-26 14:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cecc91e-2e15-4d74-c66a-01f9d72e04bf@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox