From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v3] rdma: Add bind option References: <1510181253-7632-1-git-send-email-sbates@raithlin.com> From: Jens Axboe Message-ID: <9142459b-2a3e-bedb-794d-c150a64598fd@kernel.dk> Date: Wed, 22 Nov 2017 13:15:44 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: Sitsofe Wheeler , Stephen Bates Cc: "fio@vger.kernel.org" , "logang@deltatee.com" , "elliott@hpe.com" List-ID: On 11/22/2017 01:13 PM, Sitsofe Wheeler wrote: > On 22 November 2017 at 18:01, Stephen Bates wrote: >>> In certain configurations it can be useful to bind a rdma_cm to a >>> particular network interface. For example in multi-path or loopback. >>> >>> Add a bindname option that the local rdma_cm will try and bind too. >>> >>> The bind code is based off that used in rping [1]. >>> >>> [1] https://github.com/linux-rdma/rdma-core/blob/ \ >>> master/librdmacm/examples/rping.c >>> >>> Signed-off-by: Stephen Bates >>> Reviewed-by: Logan Gunthorpe > >> >> Hi Jens >> >> Do you have any concerns or issues with this patch? > > One quick suggestion - any chance you could update the HOWTO and fio.1 > documentation to include the new ioengine parameter? Thanks Sitsofe, I somehow missed this. Yes, those options should be added to the engine specific options in both those files. -- Jens Axboe