From: Jens Axboe <axboe@kernel.dk>
To: kusumi.tomohiro@gmail.com, fio@vger.kernel.org
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: Re: [PATCH 0/4] Sync fio(1) man page with HOWTO (remaining sections)
Date: Mon, 14 Aug 2017 08:34:19 -0600 [thread overview]
Message-ID: <93d99386-6eac-36d4-7fbd-69751aa30a96@kernel.dk> (raw)
In-Reply-To: <20170813191901.33195-1-tkusumi@tuxera.com>
On 08/13/2017 01:18 PM, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> This is the continuation of below series of patches to sync the man page
> with HOWTO. It starts off from where it left off, which is job parameters
> section.
>
> [PATCH 0/7] Sync fio(1) man page with HOWTO
> http://www.spinics.net/lists/fio/msg06008.html
>
> These patches basically just sync the existing man page contents with
> HOWTO, and add/backport some minor fixes to HOWTO. They do not create
> any new contents that do not exist in either of the documents, while
> formats (e.g. indentations, directives, quotations, etc) are modified
> for some sections so that the entire man page has consistent style and
> resembles HOWTO.
>
> The patch 1/4 covers the entire job parameters section which consists
> of huge amount of diffs. I didn't separate them into smaller patches
> (e.g. 1 patch for 1 job parameter category sub section), because the
> entire syncing includes huge amount of reordering plus modification
> within the entire file, as the job parameters in the existing man page
> were not categorized by the parameter types, and separating them into
> smaller patches doesn't make them any clear, but rather unclear.
>
> Above applies to patch 2/4 as well which covers the rest of the HOWTO.
>
> Also note that there are still sections in HOWTO that are not in the
> man page. For example, these patches add all the missing options and
> parameters, but do not cover details of writing the job files with
> examples of job files, as they have never been covered in the man page.
> They could be imported to the man page as well (depending on whether
> we want the man page to be identical to HOWTO), but I have separated
> the creation of new sections from syncing the existing ones with HOWTO.
>
> The man page size (not ./fio.1 size) has increased by about 300+ lines,
> from around 1700 to 2000. Counting from prior to the previous series of
> the patches (i.e. since bdd88be^), it has increased by about 400 lines.
Are you resending this series with the issues fixed up?
--
Jens Axboe
prev parent reply other threads:[~2017-08-14 14:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 19:18 [PATCH 0/4] Sync fio(1) man page with HOWTO (remaining sections) kusumi.tomohiro
2017-08-13 19:18 ` [PATCH 1/4] man: sync "JOB PARAMETERS" section with HOWTO kusumi.tomohiro
2017-08-13 19:18 ` [PATCH 2/4] man: sync "OUTPUT" section and after " kusumi.tomohiro
2017-08-13 19:19 ` [PATCH 3/4] man: minor fixes for sections before "JOB PARAMETERS" for consistency kusumi.tomohiro
2017-08-13 19:19 ` [PATCH 4/4] HOWTO: minor fixes and backports from man page kusumi.tomohiro
2017-08-13 20:59 ` Sitsofe Wheeler
2017-08-13 21:15 ` Tomohiro Kusumi
2017-08-13 21:30 ` Tomohiro Kusumi
2017-08-14 14:34 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93d99386-6eac-36d4-7fbd-69751aa30a96@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox