Re: Cannot verify dedupe data, is it a bug?

[Jens Axboe <axboe@kernel.dk>]

On 10/18/18 2:16 AM, Changyu wrote:
> 
> Hi Jens Axboe & Sitsofe Wheeler
> 
> 
> Thank you very much for your help.
> 
> get_io_u finally call fill_io_buffer to fill the buffer, function
> fill_io_buffer uses td->buf_state and td->buf_state_prev to generate
> duplicated data if the dedupe_percentage is set.
> 
> populate_verify_io_u finally call  fill_random_buf_percentage to fill
> the buffer, it use td->verify_state to generate random data.
> 

As I said, I'm fine with that getting unified. The only thing to keep in
mind is that for verification data, we rely on being able to re-generate
the buffer contents, as long as we have a valid verify header. This can
be used to diagnose the nature of the corruption. As long as we retain
that property, the buffer generation for verify writes should follow the
same settings as non-verify writes.

> Should I create a issue on https://github.com/axboe/fio/issues?

Sure, probably check if it's a dupe of the issue Sitsofe referenced
first.


-- 
Jens Axboe