From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Vincent Fu <vincentfu@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>,
Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
Subject: Re: [PATCH v2 4/7] zbd: fix write zone accounting of trim workload
Date: Thu, 8 Jun 2023 08:14:39 +0000 [thread overview]
Message-ID: <ZIGN7hZadltFAWop@x1-carbon> (raw)
In-Reply-To: <20230608070608.1256970-5-shinichiro.kawasaki@wdc.com>
On Thu, Jun 08, 2023 at 04:06:05PM +0900, Shin'ichiro Kawasaki wrote:
> The commit e3be810bf0fd ("zbd: Support zone reset by trim") supported
> trim for zonemode=zbd by introducing the function zbd_do_io_u_trim(),
> which calls zbd_reset_zone(). However, it did not call
> zbd_write_zone_put() to the trim target zone, then trim operation
> resulted in wrong accounting of write zones.
>
> To fix the issue, call zbd_write_zone_put() from zbd_reset_zone(). To
> cover the case to reset zones without a zbd_write_zone_put() call,
> prepare another function __zbd_reset_zone(). While at it, simplify
> zbd_reset_zones() by calling the modified zbd_reset_zone().
>
> Of note is that the constifier of the argument td of do_io_u_trim() is
> removed since zbd_write_zone_put() requires changes in that argument.
>
> Fixes: e3be810bf0fd ("zbd: Support zone reset by trim")
> Suggested-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2023-06-08 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:06 [PATCH v2 0/7] zbd: clean up code and fix bugs for open zones accounting Shin'ichiro Kawasaki
2023-06-08 7:06 ` [PATCH v2 1/7] zbd: rename 'open zones' to 'write zones' Shin'ichiro Kawasaki
2023-06-08 7:06 ` [PATCH v2 2/7] zbd: do not reset extra zones in open conditions Shin'ichiro Kawasaki
2023-06-08 7:06 ` [PATCH v2 3/7] zbd: fix write zone accounting of almost full zones Shin'ichiro Kawasaki
2023-06-08 7:06 ` [PATCH v2 4/7] zbd: fix write zone accounting of trim workload Shin'ichiro Kawasaki
2023-06-08 8:14 ` Niklas Cassel [this message]
2023-06-08 7:06 ` [PATCH v2 5/7] t/zbd: reset zones before tests with max_open_zones option Shin'ichiro Kawasaki
2023-06-08 7:06 ` [PATCH v2 6/7] t/zbd: test write zone accounting of almost full zones Shin'ichiro Kawasaki
2023-06-08 7:06 ` [PATCH v2 7/7] t/zbd: test write zone accounting of trim workload Shin'ichiro Kawasaki
2023-06-08 18:45 ` [PATCH v2 0/7] zbd: clean up code and fix bugs for open zones accounting Vincent Fu
2023-06-08 19:10 ` Jens Axboe
2023-06-09 3:09 ` Shinichiro Kawasaki
2023-06-09 13:48 ` Vincent Fu
2023-06-10 0:10 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIGN7hZadltFAWop@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=Dmitry.Fomichev@wdc.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=fio@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox