From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, fio@vger.kernel.org
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH] t/zbd: Avoid magic number of test case count
Date: Thu, 26 Sep 2019 08:47:25 +0200 [thread overview]
Message-ID: <a43073c3-08c3-0273-e2e5-a3537cd238ca@kernel.dk> (raw)
In-Reply-To: <20190926010044.21020-1-shinichiro.kawasaki@wdc.com>
On 9/26/19 3:00 AM, Shin'ichiro Kawasaki wrote:
> In the test script t/zbd/test-zbd-support, the number of test cases is
> defined as a raw constant. Every time a new test case is added, need to
> update the constant but this chore tends to be overlooked. When test
> case 47 was added recently, the number was not incremented from 46. Then
> the test script does not run the test case 47.
>
> To avoid the constant increment chore, automate the test case number
> counting. List bash functions which implement test cases and convert the
> list to test case numbers.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-09-26 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 1:00 [PATCH] t/zbd: Avoid magic number of test case count Shin'ichiro Kawasaki
2019-09-26 6:47 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a43073c3-08c3-0273-e2e5-a3537cd238ca@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=fio@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox