public inbox for fio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Runa Guo-oc <RunaGuo-oc@zhaoxin.com>,
	fio@vger.kernel.org, vincentfu@gmail.com
Cc: cobechen@zhaoxin.com, tonywwang@zhaoxin.com,
	xanderchen@zhaoxin.com, louisqi@zhaoxin.com, runaguo@zhaoxin.com,
	leoliu@zhaoxin.com
Subject: Re: [PATCH] Add Zhaoxin support to enable tsc_reliable and arch_random features
Date: Wed, 21 May 2025 07:20:29 -0600	[thread overview]
Message-ID: <a6d5bbaa-4a99-4027-9bc8-94920fa9f02b@kernel.dk> (raw)
In-Reply-To: <20250521020421.6862-1-RunaGuo-oc@zhaoxin.com>

On 5/20/25 8:04 PM, Runa Guo-oc wrote:
> Signed-off-by: Runa Guo-oc <RunaGuo-oc@zhaoxin.com>

This is literally the same as the intel one, why duplicate all
of that? Just do:

diff --git a/arch/arch-x86-common.h b/arch/arch-x86-common.h
index f32835cce33b..ac26126ae84a 100644
--- a/arch/arch-x86-common.h
+++ b/arch/arch-x86-common.h
@@ -68,7 +68,8 @@ static inline void arch_init(char *envp[])
 			 (unsigned int *) &str[4]);
 
 	str[12] = '\0';
-	if (!strcmp(str, "GenuineIntel"))
+	if (!strcmp(str, "GenuineIntel") || !strcmp(str, "  Shanghai  ") ||
+	    !strcmp(str, "CentaurHauls"))
 		arch_init_intel();
 	else if (!strcmp(str, "AuthenticAMD") || !strcmp(str, "HygonGenuine"))
 		arch_init_amd();

-- 
Jens Axboe

  reply	other threads:[~2025-05-21 13:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  2:04 [PATCH] Add Zhaoxin support to enable tsc_reliable and arch_random features Runa Guo-oc
2025-05-21 13:20 ` Jens Axboe [this message]
2025-05-21 17:49 ` fiotestbot
  -- strict thread matches above, loose matches on Subject: below --
2025-05-22  4:37 Runa Guo-oc
2025-05-22  6:49 ` fiotestbot
2025-05-22  8:07 ` Sitsofe Wheeler
2025-05-22 10:40 Runa Guo-oc
2025-05-23  7:38 ` fiotestbot
2025-05-23 13:19   ` Vincent Fu
2025-05-23 15:46 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6d5bbaa-4a99-4027-9bc8-94920fa9f02b@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=RunaGuo-oc@zhaoxin.com \
    --cc=cobechen@zhaoxin.com \
    --cc=fio@vger.kernel.org \
    --cc=leoliu@zhaoxin.com \
    --cc=louisqi@zhaoxin.com \
    --cc=runaguo@zhaoxin.com \
    --cc=tonywwang@zhaoxin.com \
    --cc=vincentfu@gmail.com \
    --cc=xanderchen@zhaoxin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox