From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <damien.lemoal@wdc.com>, fio@vger.kernel.org
Subject: Re: [PATCH] zbd: Fix potential zone lock deadlock
Date: Mon, 6 Apr 2020 08:31:19 -0700 [thread overview]
Message-ID: <aaa43410-cd54-0581-e104-94a667d56551@kernel.dk> (raw)
In-Reply-To: <20200406105132.1291382-1-damien.lemoal@wdc.com>
On 4/6/20 4:51 AM, Damien Le Moal wrote:
> Commit b27aef6abfba ("zbd: use zone_lock to lock a zone") to fix
> potential deadlocks with zonemode=zbd zone locking was incomplete.
> The execution of the zone lock stress test t/zbd test case 48 still
> sometimes lead to deadlocks (a large number of repeated execution is
> sometimes needed).
>
> The remaining deadlock pattern identified with the repeated execution
> of this test is due to the concurrent execution of jobs doing random
> async writes to zones. In such case, any of the job may trigger an all
> zone reset through the path get_next_rand_block() -> fio_file_reset()
> while async writes are still inflight. The fix for this is to use the
> zone_lock() function instead of directly calling pthread_mutex_lock()i
> to ensure that no async IO is inflight for a zone that is part of a
> reset range.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-04-06 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 10:51 [PATCH] zbd: Fix potential zone lock deadlock Damien Le Moal
2020-04-06 15:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa43410-cd54-0581-e104-94a667d56551@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox