From: Keith Busch <kbusch@kernel.org>
To: Vincent Fu <vincentfu@gmail.com>
Cc: Keith Busch <kbusch@meta.com>, fio@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 1/3] eta: don't estimate runtime from an unset job epoch
Date: Wed, 9 Sep 2026 14:15:52 -0600 [thread overview]
Message-ID: <aqG-eCIozaeovkrb@kbusch-mbp> (raw)
In-Reply-To: <CAOp=CXnd3oqKZ5OC5Sv6nAkjD6k6979moPNNPoMC_SbnAJz6=Q@mail.gmail.com>
On Wed, Sep 09, 2026 at 01:01:32PM -0400, Vincent Fu wrote:
> I think a better fix would be to improve Fio's state machine so that it does
> not jump directly into TD_RUNNING from TD_INITIALIZED. Perhaps run_threads
> should promote jobs to TD_SETTING_UP instead. And after set_epoch_time()
> succeeds, transition to TD_RUNNING.
>
> The current patch is safer, but it doesn't address the underlying problem that
> a job is marked as TD_RUNNING when it actually has not attained that state. And
> It's this problem which is one of the sources of the ETA issue.
Sounds good. I thinks this suggestion will result in a cleaner result in
the end. Testing a few things now before sending a new version.
next prev parent reply other threads:[~2026-09-09 20:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 17:20 [PATCH 0/3] fio: fix eta Keith Busch
2026-09-03 17:20 ` [PATCH 1/3] eta: don't estimate runtime from an unset job epoch Keith Busch
2026-09-09 17:01 ` Vincent Fu
2026-09-09 20:15 ` Keith Busch [this message]
2026-09-03 17:21 ` [PATCH 2/3] eta: cap the ETA at the job's own remaining runtime Keith Busch
2026-09-03 17:21 ` [PATCH 3/3] eta: remove now unused done_secs Keith Busch
2026-09-03 20:01 ` [PATCH 0/3] fio: fix eta fiotestbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqG-eCIozaeovkrb@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kbusch@meta.com \
--cc=vincentfu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox