From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>
Subject: Re: [PATCH] zbd: fix sequential verify with max_open_zones=1
Date: Sat, 11 Apr 2020 14:18:56 -0600 [thread overview]
Message-ID: <b6b09ff8-1149-c662-9838-35e61a7ce295@kernel.dk> (raw)
In-Reply-To: <BY5PR04MB6900D077D39EEAF4AE35809FE7C10@BY5PR04MB6900.namprd04.prod.outlook.com>
On 4/9/20 4:41 PM, Damien Le Moal wrote:
> On 2020/04/10 2:14, Alexey Dobriyan wrote:
>> On Thu, Apr 09, 2020 at 01:58:13AM +0000, Damien Le Moal wrote:
>>> On 2020/04/09 7:16, Alexey Dobriyan wrote:
>>>> Sequential write with max_open_zones=1 has interesting (read: buggy)
>>>> interaction with verify=.
>>
>>>> + if (f->zbd_info->open_zones[i] == nz) {
>>>> + zbd_close_zone(td, f, i);
>>>> + }
>>>
>>> nit: you do not need the {} brackets for the if here.
>>
>> I started to use {} everywhere, it is less thinking that way.
>
> Sure, but that is not the coding style normally used in fio and many other open
> source C projects. I will let Jens decide here.
I prefer no braces for single lines. The exception is if/else, where if one
has braces, the rest should too. Fio isn't really consistent in the latter
I think, but definitely the former.
--
Jens Axboe
next prev parent reply other threads:[~2020-04-11 20:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 22:16 [PATCH] zbd: fix sequential verify with max_open_zones=1 Alexey Dobriyan
2020-04-09 1:58 ` Damien Le Moal
2020-04-09 17:14 ` Alexey Dobriyan
2020-04-09 22:41 ` Damien Le Moal
2020-04-10 18:46 ` Alexey Dobriyan
2020-04-11 20:18 ` Jens Axboe [this message]
2020-04-13 18:51 ` [PATCH v2] zbd: fix sequential write pattern with verify= and max_open_zones= Alexey Dobriyan
2020-04-13 23:13 ` Damien Le Moal
2020-04-13 23:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b09ff8-1149-c662-9838-35e61a7ce295@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=adobriyan@gmail.com \
--cc=fio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox