From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>, fio@vger.kernel.org
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH] t/zbd: Fix I/O bytes rounding errors
Date: Thu, 8 Aug 2019 20:36:48 -0700 [thread overview]
Message-ID: <d394655f-e02a-df7e-4ac0-a5b480a1b3bd@kernel.dk> (raw)
In-Reply-To: <20190809032836.10163-1-shinichiro.kawasaki@wdc.com>
On 8/8/19 8:28 PM, Shin'ichiro Kawasaki wrote:
> When fio reports write bytes or read bytes, it rounds the number with
> units MiB or KiB to fit the number within limited number of digits.
> This results in rounding errors of the reported bytes and sometimes
> causes test failures for test case #17 in test-zbd-support
> which reports incorrect total I/O bytes in case both of write bytes
> and read bytes are rounded up.
>
> To avoid the rounding error, increase the number of digits from default
> value 4 to 10 to keep precision. For example, a number "256MiB" will be
> reported as "267911168B" with this change.
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2019-08-09 3:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 3:28 [PATCH] t/zbd: Fix I/O bytes rounding errors Shin'ichiro Kawasaki
2019-08-09 3:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d394655f-e02a-df7e-4ac0-a5b480a1b3bd@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=fio@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox