public inbox for fio@vger.kernel.org
 help / color / mirror / Atom feed
From: Vincent Fu <vincentfu@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
	vincent.fu@samsung.com, fio@vger.kernel.org
Subject: Re: [PATCH 1/2] configure: libnfs + gnutls
Date: Fri, 25 Jul 2025 13:44:49 -0400	[thread overview]
Message-ID: <db1480d0-eafc-48a1-bcbf-50a06c25a6ff@gmail.com> (raw)
In-Reply-To: <20250725061748.2180898-2-mcgrof@kernel.org>

On 7/25/25 2:17 AM, Luis Chamberlain wrote:
> The problem is that the configure script tries to get both libnfs and
> gnutls flags together, but gnutls is missing. Let me check the configure
> script's logic and fix it:
> 
> The configure script is trying to link both libnfs and gnutls together,
> but gnutls is not installed. Let me fix this by modifying the configure
> script to only require libnfs:
> 
> Generated-by: Claude AI
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>   configure | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 9e69dc4b..1769ef38 100755
> --- a/configure
> +++ b/configure
> @@ -2359,8 +2359,8 @@ print_config "DAOS File System (dfs) Engine" "$dfs"
>   if test "$libnfs" != "no" ; then
>     if $(pkg-config libnfs > /dev/null 2>&1); then
>       libnfs="yes"
> -    libnfs_cflags=$(pkg-config --cflags libnfs gnutls)
> -    libnfs_libs=$(pkg-config --libs libnfs gnutls)
> +    libnfs_cflags=$(pkg-config --cflags libnfs)
> +    libnfs_libs=$(pkg-config --libs libnfs)
>     else
>       if test "$libnfs" = "yes" ; then
>         feature_not_found "libnfs" "libnfs"

The gnutls requirement was added via

https://lore.kernel.org/fio/4369d6e2-48d4-43cb-965a-b376dc559dad@gmail.com/T/#t

I can think of two ways to resolve this:

- Make sure gnutls is installed when building fio
- Modify the configure script to detect whether or not gnutls really is 
needed by libnfs and set up the flags accordingly

Vincent

  reply	other threads:[~2025-07-25 17:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25  6:17 [PATCH 0/2] fio: steady state for latency Luis Chamberlain
2025-07-25  6:17 ` [PATCH 1/2] configure: libnfs + gnutls Luis Chamberlain
2025-07-25 17:44   ` Vincent Fu [this message]
2025-07-25  6:17 ` [PATCH 2/2] fio: add latency steady state detection Luis Chamberlain
2025-07-28 18:14   ` Vincent Fu
2025-07-28 21:27   ` Sitsofe Wheeler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db1480d0-eafc-48a1-bcbf-50a06c25a6ff@gmail.com \
    --to=vincentfu@gmail.com \
    --cc=fio@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox