From: Jens Axboe <axboe@kernel.dk>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: fio@vger.kernel.org
Subject: Re: Is the libiscsi engine patch applied correctly?
Date: Thu, 25 Apr 2019 14:25:12 -0600 [thread overview]
Message-ID: <dfd9f9f0-12ac-0cf5-2bde-a84b3c1d16dc@kernel.dk> (raw)
In-Reply-To: <20190425202214.GL3926@redhat.com>
On 4/25/19 2:22 PM, Richard W.M. Jones wrote:
> On Thu, Apr 25, 2019 at 10:10:40AM -0600, Jens Axboe wrote:
>> On 4/25/19 9:52 AM, Richard W.M. Jones wrote:
>>> It seems like these two lines might be in the wrong order? (and the
>>> same thing later in the file too)
>>>
>>> https://github.com/axboe/fio/blob/afc22c98609ee80a99fbed24231181bdab2bc659/optgroup.h#L65-L66
>>
>> They are, that's a bug. Thanks for letting me know, I've fixed it up.
>
> Thanks. I think also these lines later in the same file -- although
> not technically a bug -- should also be swapped around:
>
> FIO_OPT_G_INVALID = (1ULL << __FIO_OPT_G_NR),
> FIO_OPT_G_ISCSI = (1ULL << __FIO_OPT_G_ISCSI),
Order of those don't really matter. But for pure aesthetics, yeah they
should probably be swapped.
--
Jens Axboe
prev parent reply other threads:[~2019-04-25 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 15:52 Is the libiscsi engine patch applied correctly? Richard W.M. Jones
2019-04-25 16:10 ` Jens Axboe
2019-04-25 20:22 ` Richard W.M. Jones
2019-04-25 20:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfd9f9f0-12ac-0cf5-2bde-a84b3c1d16dc@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox