Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: vincentfu@gmail.com, fio@vger.kernel.org
Cc: Vincent Fu <vincent.fu@wdc.com>
Subject: Re: [PATCH] gettime: use nsec in get_cycles_per_msec division
Date: Thu, 29 Nov 2018 11:21:36 -0700	[thread overview]
Message-ID: <e784e513-65b4-bb28-8487-347ae467f5f5@kernel.dk> (raw)
In-Reply-To: <20181129181418.24788-1-vincentfu@gmail.com>

On 11/29/18 11:14 AM, vincentfu@gmail.com wrote:
> From: Vincent Fu <vincent.fu@wdc.com>
> 
> Since we now have ntime_since() we can use nsec in the division for
> get_cycles_per_msec(). This makes the cycles_per_msec value that fio
> ultimately uses more stable since fio will no longer be using values
> truncated to usec.
> 
> While we're here also modify some debug prints to make it explicit that
> fio ultimately uses a trimmed mean in its time calculations.
> 
> On platforms where only gettimeofday() is available this will be no
> worse than the original code since we will revert back to using times
> truncated to usec.
> 
> With the patch, the last three digits of the trimmed mean have a tight
> range from 784-786. Without the patch, the corresponding value (labeled
> avg) has a much wider range from 821-958. Notice also that the standard
> error S is an order of magnitude smaller with the patch.

This is great, thanks Vincent. Applied.

-- 
Jens Axboe



  reply	other threads:[~2018-11-29 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 18:14 [PATCH] gettime: use nsec in get_cycles_per_msec division vincentfu
2018-11-29 18:21 ` Jens Axboe [this message]
2018-11-29 18:31   ` Vincent Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e784e513-65b4-bb28-8487-347ae467f5f5@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=vincent.fu@wdc.com \
    --cc=vincentfu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox