Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <damien.lemoal@wdc.com>, fio@vger.kernel.org
Subject: Re: [PATCH 1/3] zbd: Fix missing mutex unlock and warnings detected with coverity
Date: Wed, 8 Apr 2020 07:44:07 -0700	[thread overview]
Message-ID: <f0af29de-e840-2867-0701-97237135cb43@kernel.dk> (raw)
In-Reply-To: <20200408064645.1621805-1-damien.lemoal@wdc.com>

On 4/7/20 11:46 PM, Damien Le Moal wrote:
> With max_open_zones != 0, if no candidate zone for open is found by
> zbd_convert_to_open_zone(), the file zbd_info mutex as well as the
> current target zone mutex must both be unlocked before returning NULL.
> 
> While at it, also assert check for min_bs != 0 where min_bs is used for
> divisions to avoid division by zero warnings from coverity.

You forgot the cover letter, so replying to this one. Applied 1-3 (v2).

-- 
Jens Axboe



      reply	other threads:[~2020-04-08 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  6:46 [PATCH 1/3] zbd: Fix missing mutex unlock and warnings detected with coverity Damien Le Moal
2020-04-08 14:44 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0af29de-e840-2867-0701-97237135cb43@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox