Flexible I/O Tester development
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Andreas Herrmann <aherrmann@suse.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH v3 0/4] stat: Modify info for bw and add iops stats
Date: Fri, 23 Jun 2017 12:15:34 -0600	[thread overview]
Message-ID: <febe06de-7c82-698f-15df-d1282011ec49@fb.com> (raw)
In-Reply-To: <20170623174300.7937-1-aherrmann@suse.com>

On 06/23/2017 11:42 AM, Andreas Herrmann wrote:
> Hi,
> 
> this is a resubmission of patches 1 and 2 to add iops statistics and
> number of samples for iops and bw stats to normal and json output
> formats. Patches are rebased on fio-2.21-26-gcf6b7fb4.
> 
> I'd like to see similar information added to terse format. Thus I've
> added patches 3 and 4. First to merge terse functions (reducing code
> size) and then to add a new terse format 5 where iops stats and number
> of samples for bw and iops are displayed.

Looks good, I like it. Patch #4 needs an explanation of version 5
of the terse format, though. Care to add that?

-- 
Jens Axboe


  parent reply	other threads:[~2017-06-23 18:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 17:42 [PATCH v3 0/4] stat: Modify info for bw and add iops stats Andreas Herrmann
2017-06-23 17:42 ` [PATCH 1/4] stat: Print one-line iops stat Andreas Herrmann
2017-06-23 18:26   ` Jens Axboe
2017-06-23 19:47     ` Andreas Herrmann
2017-06-23 17:42 ` [PATCH 2/4] stat: Print number of samples in bw and iops stats Andreas Herrmann
2017-06-23 17:42 ` [PATCH 3/4] stat: Merge show_thread_status_terse_* functions Andreas Herrmann
2017-06-23 17:43 ` [PATCH 4/4] stat: Add iops stat and sample number information to terse format Andreas Herrmann
2017-06-23 18:15 ` Jens Axboe [this message]
2017-06-23 19:45   ` [PATCH v3 0/4] stat: Modify info for bw and add iops stats Andreas Herrmann
2017-06-23 19:56     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=febe06de-7c82-698f-15df-d1282011ec49@fb.com \
    --to=axboe@fb.com \
    --cc=aherrmann@suse.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox