From: Ritesh Harjani <riteshh@linux.ibm.com>
To: fstests@vger.kernel.org
Cc: guan@eryu.me, anju@linux.vnet.ibm.com,
Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCH 2/3] common/rc: Add _require_get_hugepagesize and fix _require_label_get_max
Date: Thu, 11 Feb 2021 09:01:45 +0530 [thread overview]
Message-ID: <05dbc4b37d77e03bc288feb07815f737efbf2abd.1612951443.git.riteshh@linux.ibm.com> (raw)
In-Reply-To: <cover.1612951443.git.riteshh@linux.ibm.com>
_notrun executed from a subshell $(cmd) won't exit it's parent.
Hence _require_*** functions shouldn't have below statements.
dummy=$(_label_get_max)
Also add a function _require_get_hugepagesize(), since it seems the
intention of _get_hugepagesize() is to also '_notrun' when the hugepagesize
is not a valid number.
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
---
common/rc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 649b1cfd884a..1831714198af 100644
--- a/common/rc
+++ b/common/rc
@@ -175,6 +175,12 @@ _get_hugepagesize()
echo $((hugepgsz * 1024))
}
+_require_get_hugepagesize()
+{
+ # Just a dummy for _notrun if hugepagesize is not supported
+ _get_hugepagesize
+}
+
_mount()
{
$MOUNT_PROG `_mount_ops_filter $*`
@@ -4250,7 +4256,7 @@ _label_get_max()
_require_label_get_max()
{
# Just call _label_get_max which will notrun if appropriate
- dummy=$(_label_get_max)
+ _label_get_max
}
_dmsetup_remove()
--
next prev parent reply other threads:[~2021-02-11 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 3:31 [PATCH 0/3] fstests: -I <n> CLI option and some random fixes Ritesh Harjani
2021-02-11 3:31 ` [PATCHv2 1/3] check: add CLI option to repeat and stop tests in case of failure Ritesh Harjani
2021-02-11 3:31 ` Ritesh Harjani [this message]
2021-03-07 16:00 ` [PATCH 2/3] common/rc: Add _require_get_hugepagesize and fix _require_label_get_max Eryu Guan
2021-02-11 3:31 ` [PATCH 3/3] generic/{413/605}: Add _require_get_hugepagesize check Ritesh Harjani
2021-03-01 6:01 ` [PATCH 0/3] fstests: -I <n> CLI option and some random fixes Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05dbc4b37d77e03bc288feb07815f737efbf2abd.1612951443.git.riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=anju@linux.vnet.ibm.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox