From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org ([198.145.29.99]:39784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726972AbeJGU7J (ORCPT ); Sun, 7 Oct 2018 16:59:09 -0400 Subject: Re: [PATCH 1/2] check: recognize f2fs through parameter References: <20180930092653.122684-1-yuchao0@huawei.com> <20181006093207.GI17817@desktop> From: Chao Yu Message-ID: <05f43b5d-0e67-ba87-63dd-e45e8bd4c371@kernel.org> Date: Sun, 7 Oct 2018 21:51:48 +0800 MIME-Version: 1.0 In-Reply-To: <20181006093207.GI17817@desktop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: Eryu Guan , Chao Yu Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net List-ID: On 2018-10-6 17:32, Eryu Guan wrote: > On Sun, Sep 30, 2018 at 05:26:52PM +0800, Chao Yu wrote: >> Add a paramenter in check to configure $FSTYP for f2fs. >> >> Signed-off-by: Chao Yu >> --- >> check | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/check b/check >> index f3c8021d94b9..a9024094721a 100755 >> --- a/check >> +++ b/check >> @@ -59,6 +59,7 @@ check options >> -pvfs2 test PVFS2 >> -tmpfs test TMPFS >> -ubifs test ubifs >> + -f2fs test f2fs >> -l line mode diff >> -udiff show unified diff (default) >> -n show me, do not run tests >> @@ -263,6 +264,7 @@ while [ $# -gt 0 ]; do >> -pvfs2) FSTYP=pvfs2 ;; >> -tmpfs) FSTYP=tmpfs ;; >> -ubifs) FSTYP=ubifs ;; >> + -f2fs) FSTYP=f2fs ;; > > The test harness should be able to detect the f2fs type from $TEST_DEV. > We add param to set FSTYP only when there's no way to tell the > filesystem type from the device. Hi Eryu, Okay, thanks for the explanation, let's just ignore this patch. Thanks, > > Thanks, > Eryu > >> >> -g) group=$2 ; shift ; >> GROUP_LIST="$GROUP_LIST ${group//,/ }" >> -- >> 2.18.0.rc1 >>