public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-xfs@vger.kernel.org,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCH] xfs/604: Make test as _notrun for higher blocksizes filesystem
Date: Fri, 19 Jan 2024 14:57:45 +0530	[thread overview]
Message-ID: <070f1491c25c37d2a9e01a40aebe87f3404a4b69.1705656364.git.ritesh.list@gmail.com> (raw)

If we have filesystem with blocksize = 64k, then the falloc value will
be huge which makes fallocate fail hence causing the test to fail.
Instead make the testcase "_notrun" if the fallocate itself fails.

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
 tests/xfs/604 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/604 b/tests/xfs/604
index bb6db797..40596a28 100755
--- a/tests/xfs/604
+++ b/tests/xfs/604
@@ -35,7 +35,8 @@ allocbt_node_maxrecs=$(((dbsize - alloc_block_len) / 12))
 # Create a big file with a size such that the punches below create the exact
 # free extents we want.
 num_holes=$((allocbt_leaf_maxrecs * allocbt_node_maxrecs - 1))
-$XFS_IO_PROG -c "falloc 0 $((9 * dbsize + num_holes * dbsize * 2))" -f "$SCRATCH_MNT/big"
+$XFS_IO_PROG -c "falloc 0 $((9 * dbsize + num_holes * dbsize * 2))" -f "$SCRATCH_MNT/big" ||
+				_notrun "Not enough space on device for bs=$dbsize"
 
 # Fill in any small free extents in AG 0. After this, there should be only one,
 # large free extent.
-- 
2.43.0


             reply	other threads:[~2024-01-19  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  9:27 Ritesh Harjani (IBM) [this message]
2024-01-21  4:56 ` [PATCH] xfs/604: Make test as _notrun for higher blocksizes filesystem Darrick J. Wong
2024-01-22  6:29   ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=070f1491c25c37d2a9e01a40aebe87f3404a4b69.1705656364.git.ritesh.list@gmail.com \
    --to=ritesh.list@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox